Skip to content

Commit

Permalink
Merge pull request #4575 from richardcase/fix_eks_e2e
Browse files Browse the repository at this point in the history
fix: eks e2e test failing as subnet name was used
  • Loading branch information
k8s-ci-robot authored Oct 30, 2023
2 parents 1f1fa69 + e53f691 commit 9b5d146
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/cloud/services/eks/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,8 @@ func makeVpcConfig(subnets infrav1.Subnets, endpointAccess ekscontrolplanev1.End
subnetIds := make([]*string, 0)
for i := range subnets {
subnet := subnets[i]
subnetIds = append(subnetIds, &subnet.ID)
subnetID := subnet.GetResourceID()
subnetIds = append(subnetIds, &subnetID)
}

cidrs := make([]*string, 0)
Expand Down
1 change: 1 addition & 0 deletions pkg/cloud/services/network/routetables.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ func (s *Service) reconcileRouteTables() error {
// Not recording "SuccessfulTagRouteTable" here as we don't know if this was a no-op or an actual change
continue
}
s.scope.Debug("Subnet isn't associated with route table", "subnet-id", sn.GetResourceID())

// For each subnet that doesn't have a routing table associated with it,
// create a new table with the appropriate default routes and associate it to the subnet.
Expand Down

0 comments on commit 9b5d146

Please sign in to comment.