Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] fix: wrong EKS tag when upgrading older clusters #3787

Conversation

dlipovetsky
Copy link
Contributor

Manual cherry-pick of #3783.

The automated cherry-pick failed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2022
@dlipovetsky dlipovetsky changed the title [release-1.5] fix: wrong EKS tag when upgrading older clusters #3786 [release-1.5] fix: wrong EKS tag when upgrading older clusters #3787 Oct 19, 2022
@dlipovetsky dlipovetsky changed the title [release-1.5] fix: wrong EKS tag when upgrading older clusters #3787 [release-1.5] fix: wrong EKS tag when upgrading older clusters Oct 19, 2022
@dlipovetsky
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@dlipovetsky: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dkoshkin
Copy link
Contributor

Thanks!

@Skarlso
Copy link
Contributor

Skarlso commented Oct 20, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2022
@Skarlso
Copy link
Contributor

Skarlso commented Oct 20, 2022

/assign @sedefsavas

@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase, Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 75913e9 into kubernetes-sigs:release-1.5 Oct 20, 2022
@richardcase
Copy link
Member

/milestone v1.5.3

@k8s-ci-robot k8s-ci-robot added this to the v1.5.3 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants