fix: wrong EKS tag when upgrading older clusters

[dkoshkin]

What type of PR is this?
/kind bug

What this PR does / why we need it:
After #3573, the AWS tag on a EKS cluster was changed. This was a good change to make everything more consistent, but it broke upgrading EKS clusters that were created with CAPA < v1.5.0.

In this PR, both the new and the previous tag formats will be checked and only fail if both are nil.

I also took the opportunity to clean up the error message, here is what it looked like before. It wasn't very clear what it was looking for and printed a nil error.

    - lastTransitionTime: "2022-09-22T10:01:30Z"
      message: 'checking owner of default_e2e-eks-upgrade-test-3618755-control-plane
        is e2e-eks-upgrade-test-3618755: %!!(MISSING)w(<nil>)'

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

[dlipovetsky]

/cherrypick release-1.5

[k8s-infra-cherrypick-robot]

@dlipovetsky: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dlipovetsky]

/cherrypick release-1.6

[k8s-infra-cherrypick-robot]

@dlipovetsky: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dlipovetsky]

We test Kubernetes version upgrades using the same CAPA version for managed clusters, but I do not think we test CAPA upgrades themselves.

It would be nice to think of lighter-weight test that could catch this type of bug, but testing a CAPA upgrade would definitely work.

[faiq]

This is a really nice change. Should we consider removing the old tag as well and potentially getting rid of this extra code moving forward?

[dlipovetsky]

/priority urgent

[k8s-ci-robot]

@dlipovetsky: The label(s) priority/urgent cannot be applied, because the repository doesn't have them.

In response to this:

/priority urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dlipovetsky]

/triage accepted

As far as I understand it, v1.5.0 and v2.0-beta are unable to reconcile an EKS cluster created with an earlier CAPA version, e.g., v1.4.x.

/priority critical-urgent

[dlipovetsky]

/lgtm

[Skarlso]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skarlso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Skarlso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Skarlso]

/hold

[Skarlso]

/hold cancel

[k8s-infra-cherrypick-robot]

@dlipovetsky: new pull request created: #3786

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@dlipovetsky: #3783 failed to apply on top of branch "release-1.5":

Applying: fix: wrong EKS tag when upgrading older clusters
Using index info to reconstruct a base tree...
M	pkg/cloud/services/eks/cluster.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloud/services/eks/cluster.go
CONFLICT (content): Merge conflict in pkg/cloud/services/eks/cluster.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: wrong EKS tag when upgrading older clusters
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dlipovetsky]

I'll look into the release-1.5 backport

[dlipovetsky]

/cherrypick release-2.0

[k8s-infra-cherrypick-robot]

@dlipovetsky: new pull request created: #3788

In response to this:

/cherrypick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.