[release-1.5] fix: use v1beta1 version in EKS user kubeconfig #3763
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-priority
size/XS
|
Looking into the failure. |
|
There's a failure in the I don't see any changes in this PR, or between release-1.5 and main, that appear to be related to the test failure. I'll re-run the test. |
|
/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5 |
|
A different test, "Should successfully create a cluster with machine pool machines" failed. It passed the first run. I'll re-run again. |
|
/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5 |
|
This PR only affects managed (EKS) clusters, but the failing tests in |
|
/test pull-cluster-api-provider-aws-e2e-blocking-release-1-5 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@sedefsavas I think this is worth merging into release-1.5 We can decide separately whether or not to release 1.5.1 |
|
/approve |
|
/approve This should now work, shouldn't it? 🤔 |
|
It looks like the maintainer approval has no effect because the https://github.com/orgs/kubernetes-sigs/teams/cluster-api-provider-aws-maintainers is not up to date. I'll raise this on slack. Update: We'll be able to approve once we backport the maintainer metadata to release-1.5 (#3807) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitasw, richardcase, Skarlso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This is an automated cherry-pick of #3740
/assign dlipovetsky