-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use v1beta1 version in EKS user kubeconfig #3740
fix: use v1beta1 version in EKS user kubeconfig #3740
Conversation
/lgtm |
// Version v1 was released in Kubernetes v1.23. | ||
// Version v1beta1 was selected as it has the widest range of support | ||
// This should be changed to v1 once EKS no longer supports Kubernetes <v1.23 | ||
execConfig := &api.ExecConfig{APIVersion: "client.authentication.k8s.io/v1beta1"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah the last version was 1.19 with alpha, right? So this should be okay and not affect existing clusters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like 1.10 was the last version with no beta and only alpha https://github.com/kubernetes/kubernetes/tree/release-1.10/staging/src/k8s.io/client-go/pkg/apis/clientauthentication
I doubt anyone is still using that version, and definitely would not be able to install a new cluster with it.
I've been running into this a lot lately 🤣 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.5 I think this fix needs to be in the next 1.5 patch release. |
@dlipovetsky: new pull request created: #3763 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.6 |
@dlipovetsky: new pull request created: #3781 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
client.authentication.k8s.io/v1alpha1
has been removed in Kubernetes v1.24 see aws/aws-cli#6920. EKS will soon support v1.24, to prepare for that we should use a version that will be supported. This also breaks anyone that useskubectl
>=1.24, so others may already be seeing this issue.The oldest version that EKS supports is v1.20 https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html where
v1beta1
was already available (and is still available even in 1.26)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: