fix: Generate, but do not write to the spec, the default API server ELB name

[dlipovetsky]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Instead of writing the generated API server ELB name to the AWSCluster Spec, generates it at runtime. Writing the value to the spec inadvertently broke the ability of v1.0.0 controllers to update AWSCluster resource created by a v1.1.0 controller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3003

Special notes for your reviewer:
An AWSCluster created by a v1.1.0 controller already has its generated name written to the Spec. As of this PR, the generated name will not be written to the Spec. I don't think this is an issue, but wanted to note it.

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

TODO

[k8s-ci-robot]

@dlipovetsky: The label(s) kind/ cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
Instead of writing the generated API server ELB name to the AWSCluster Spec, generates it at runtime. Writing the value to the spec inadvertently broke the ability of v1.0.0 controllers to update AWSCluster resource created by a v1.1.0 controller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3003

Special notes for your reviewer:
An AWSCluster created by a v1.1.0 controller already has its generated name written to the Spec. As of this PR, the generated name will not be written to the Spec. I don't think this is an issue, but wanted to note it.

Checklist:

• squashed commits
• includes documentation
• adds unit tests
• adds or updates e2e tests

Release note:

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@dlipovetsky: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sedefsavas]

v1alpha4 upgrade failed but may just be timed out, restarted the test in the other PR.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/directory/pull-cluster-api-provider-aws-e2e/1468223140587900928

[sedefsavas]

/test pull-cluster-api-provider-aws-e2e

[dlipovetsky]

I'd like to squash the fixups, just let me know when.

[sedefsavas]

There is a known issue with GPU e2e test, I am only observing v1alpha3/v1alpha4 --> v1beta1 upgrade.

v1alpha3 --> v1beta1 upgrade failed, waiting for the logs.

[sedefsavas]

/test pull-cluster-api-provider-aws-e2e

[sedefsavas]

/test pull-cluster-api-provider-aws-e2e

The error was:
[4] Error: failed to get provider components for the "kubeadm:v0.3.23" provider: failed to parse yaml: failed to unmarshal the 1st yaml document: "\ufeff<?xml version=\"1.0\" encoding=\"utf-8\"?><Error><Code>ServerBusy</Code><Message>Egress is over the account limit.\nRequestId:e2cccbac-701e-005c-0211-ec773d000000\nTime:2021-12-08T08:54:32.7332372Z</Message></Error>\n": error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go value of type map[string]interface {}

[sedefsavas]

/test pull-cluster-api-provider-aws-e2e

[sedefsavas]

/test pull-cluster-api-provider-aws-e2e

[sedefsavas]

I am suspecting that the failures are because of AWS or networking issues. Because the tests passed in the other PR with the same code (GPU failure is a known issue):
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3005/pull-cluster-api-provider-aws-e2e/1468329832155713536

[sedefsavas]

Upgrade tests passed, the one failed timed out.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3004/pull-cluster-api-provider-aws-e2e/1468577599973232640

To see Cluster Upgrade spec - Single Control Plane Cluster test passing, rerrunning e2e.
@dlipovetsky you are good to squash.

[sedefsavas]

/test pull-cluster-api-provider-aws-e2e

[dlipovetsky]

The e2e passed: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/3004/pull-cluster-api-provider-aws-e2e/1468615298205618176. Squashing.

[dlipovetsky]

(I squashed the fixups, but I'd like to keep the 3 commits separate, for clarity)

[sedefsavas]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sedefsavas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sedefsavas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sedefsavas]

Thanks @dlipovetsky for the quick fix!!