Skip to content

Commit

Permalink
Add warning to prevent unintended breaking changes
Browse files Browse the repository at this point in the history
  • Loading branch information
dlipovetsky committed Dec 8, 2021
1 parent 2cd2f49 commit ab61b2d
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/cloud/services/elb/loadbalancer.go
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,11 @@ func ELBName(s scope.ELBScope) (string, error) {
// GenerateELBName generates a formatted ELB name via either
// concatenating the cluster name to the "-apiserver" suffix
// or computing a hash for clusters with names above 32 characters.
//
// WARNING If this function's output is changed, a controller using the
// new function will fail to generate the load balancer of an existing
// cluster whose load balancer name was generated using the old
// function.
func GenerateELBName(clusterName string) (string, error) {
standardELBName := generateStandardELBName(clusterName)
if len(standardELBName) <= 32 {
Expand Down

0 comments on commit ab61b2d

Please sign in to comment.