Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node affinity rules indentation in external CCM CRDs #2723

Merged
merged 1 commit into from
Aug 31, 2021
Merged

fix: node affinity rules indentation in external CCM CRDs #2723

merged 1 commit into from
Aug 31, 2021

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Aug 31, 2021 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix for failing e2e test in #2722

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2021
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@randomvariable
Copy link
Member

/hold
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@Ankitasw
Copy link
Member Author

Ankitasw commented Aug 31, 2021 •
edited
Loading

/hold
/lgtm
/approve

@randomvariable E2E tests are passing now

@Ankitasw
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit 762e320 into kubernetes-sigs:main Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Aug 31, 2021
@Ankitasw Ankitasw deleted the ccm-affinity branch August 31, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthorsen dthorsen Awaiting requested review from dthorsen

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankitasw @randomvariable @k8s-ci-robot