Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node affinity rules in external CCM CRDs #2722

Merged
merged 1 commit into from
Aug 31, 2021
Merged

fix: node affinity rules in external CCM CRDs #2722

merged 1 commit into from
Aug 31, 2021

Conversation

Ankitasw
Copy link
Member

@Ankitasw Ankitasw commented Aug 31, 2021 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Follow up of #2647
Added node affinity rules for external cloud provider as well.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2021
@randomvariable
Copy link
Member

/lgtm
/approve
/area testing
/priority important-soon

@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2021
@randomvariable randomvariable added kind/bug Categorizes issue or PR as related to a bug. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 31, 2021
@Ankitasw
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e

@k8s-ci-robot k8s-ci-robot merged commit 8c54bea into kubernetes-sigs:main Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.7.0 milestone Aug 31, 2021
@Ankitasw Ankitasw deleted the ccm-affinity branch August 31, 2021 12:57
@Ankitasw Ankitasw mentioned this pull request Aug 31, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthorsen dthorsen Awaiting requested review from dthorsen

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Ankitasw @randomvariable @k8s-ci-robot