-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add addtional linters #2517
🌱 Add addtional linters #2517
Conversation
Hi @tech-geek29. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
aa05fc9
to
535d13f
Compare
/lgtm |
LGTM after rebase. |
535d13f
to
31bb3d8
Compare
Rebase done! |
Thanks @tech-geek29 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sedefsavas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Part of our ongoing effort to enable more linters to take the human equation out of enforcing and catching minor issues.
This enables the exportloopref, ifshort, and nilerr linters.
This PR also removes
golint
linter as it is deprecated.Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related #2471
Release note: