Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable additional linters #2471

Closed
sedefsavas opened this issue Jun 4, 2021 · 10 comments
Closed

Enable additional linters #2471

sedefsavas opened this issue Jun 4, 2021 · 10 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Milestone

Comments

@sedefsavas
Copy link
Contributor

Follow-up issue to #2414

Enable the following linters:

  • stylecheck
  • errcheck
  • gosec

Also, these are some relevant PRs in cluster-api repo. We should compare what we have with the ones added there.
kubernetes-sigs/cluster-api#4649
kubernetes-sigs/cluster-api#4624
kubernetes-sigs/cluster-api#4657
kubernetes-sigs/cluster-api#4631
kubernetes-sigs/cluster-api#4697

/good-first-issue
/milestone Next

@k8s-ci-robot
Copy link
Contributor

@sedefsavas:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Follow-up issue to #2414

Enable the following linters:

  • stylecheck
  • errcheck
  • gosec

Also, these are some relevant PRs in cluster-api repo. We should compare what we have with the ones added there.
kubernetes-sigs/cluster-api#4649
kubernetes-sigs/cluster-api#4624
kubernetes-sigs/cluster-api#4657
kubernetes-sigs/cluster-api#4631
kubernetes-sigs/cluster-api#4697

/good-first-issue
/milestone Next

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the Next milestone Jun 4, 2021
@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 4, 2021
@JacekDuszenko
Copy link

Hey, I'd like to have a try on this task :)
/assign @JacekDuszenko

@tech-geek29
Copy link
Contributor

tech-geek29 commented Jun 16, 2021

Hi @JacekDuszenko are you still working on this or can I assign it to myself? I have done the relevant changes and can raise a PR!

@JacekDuszenko
Copy link

Sure, go for it if you want to, I'm working on sth else right now @tech-geek29

@tech-geek29
Copy link
Contributor

/unassign @JacekDuszenko
/assign

@tech-geek29
Copy link
Contributor

@sedefsavas:Does this issue still needs to be kept open?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 15, 2021
@randomvariable
Copy link
Member

This is fixed I think
/close

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closing this issue.

In response to this:

This is fixed I think
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants