Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CRD migration #220

Closed
wants to merge 4 commits into from
Closed

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Oct 10, 2018

Please see these links to get started with this branch:

  1. https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/220/files#diff-c94044d54155a8e95ee8b9e974624b79
  2. https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/220/files#diff-9f7d33afeb926943902257c11bba3168R80

What this PR does / why we need it:
This is a WIP!

This is the migration to CRDs

It is currently broken because of this issue:

E1010 22:45:07.077537 1 actuator.go:101] failed to store provider status for cluster "test1": the server could not find the requested resource (put clusters.cluster.k8s.io test1)

This was after giving administrator access with RBAC to the default system account

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #126

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Use CRDs

Signed-off-by: Chuck Ha <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2018
@chuckha
Copy link
Contributor Author

chuckha commented Oct 10, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2018
Chuck Ha added 3 commits October 10, 2018 19:15
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@chuckha: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-provider-aws-test a3eb84b link /test pull-cluster-api-provider-aws-test
pull-cluster-api-provider-aws-build a3eb84b link /test pull-cluster-api-provider-aws-build
pull-cluster-api-provider-aws-make a3eb84b link /test pull-cluster-api-provider-aws-make

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vincepri
Copy link
Member

Closing as the other PRs already got in.

/close

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this PR.

In response to this:

Closing as the other PRs already got in.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre pushed a commit to enxebre/cluster-api-provider-aws-2 that referenced this pull request Jul 5, 2019
…er-id-when-placement-is-nil

Check if placement is not nil before accessing AvailabilityZone field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants