-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CRD migration #220
[WIP] CRD migration #220
Conversation
Signed-off-by: Chuck Ha <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
Signed-off-by: Chuck Ha <[email protected]>
@chuckha: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing as the other PRs already got in. /close |
@vincepri: Closing this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…er-id-when-placement-is-nil Check if placement is not nil before accessing AvailabilityZone field
Please see these links to get started with this branch:
What this PR does / why we need it:
This is a WIP!
This is the migration to CRDs
It is currently broken because of this issue:
E1010 22:45:07.077537 1 actuator.go:101] failed to store provider status for cluster "test1": the server could not find the requested resource (put clusters.cluster.k8s.io test1)
This was after giving administrator access with RBAC to the default system account
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #126
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.