Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reevaluate controller structure on CRD converesions #126

Closed
liztio opened this issue Sep 27, 2018 · 0 comments
Closed

Reevaluate controller structure on CRD converesions #126

liztio opened this issue Sep 27, 2018 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@liztio
Copy link
Contributor

liztio commented Sep 27, 2018 •
edited
Loading

/kind feature

Cluster controller currently cannot exit cleanly, or doesn't obviously do so. the select {} statement is confusing, and RunAsync is a misnomer.

https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/cloud/aws/controllers/cluster/controller.go#L87-L89

A lot of cruft is a result of of the apibuilder, and once we move to CRDs we should cull as much as possible.
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 27, 2018
@liztio liztio changed the title Reevaluate initialisation routines on CRD converesions Reevaluate controller structure on CRD converesions Sep 27, 2018
@detiber detiber added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 2, 2018
@detiber detiber added this to the v1alpha2 milestone Oct 2, 2018
@chuckha chuckha mentioned this issue Oct 10, 2018
Closed
@detiber detiber removed this from the v1alpha2 milestone Oct 17, 2018
@detiber detiber closed this as completed Oct 17, 2018
paulfantom pushed a commit to paulfantom/cluster-api-provider-aws that referenced this issue Jan 3, 2019
@openshift-merge-robot
Merge pull request kubernetes-sigs#126 from enxebre/owners
e8ed700 
Remove user from owners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@detiber @k8s-ci-robot @liztio