Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: initial EKS e2e tests #2168

Merged
merged 3 commits into from
Dec 18, 2020
Merged

✨ feat: initial EKS e2e tests #2168

merged 3 commits into from
Dec 18, 2020

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Dec 14, 2020 •
edited
Loading

What this PR does / why we need it:

Initial EKS e2e tests. Due to the time it takes to provision eks clusters in AWS we don't create clusters in BeforeEach and try
to do tests in steps. Additional tests will be added in the future via separate PRs. The tests make use of the bootstrap user credentials as the current e2e user doesn't have the required permissions.

Also includes a few additional fixes as a result of testing:

  • Permissions for machine pools
  • Permissions for EKS service linked roles

Which issue(s) this PR fixes :
Fixes #1907
Fixes #2166

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 14, 2020
@richardcase
Copy link
Member Author

I will add a job at a later date here: https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/cluster-api-provider-aws

@richardcase
Copy link
Member Author

Ready for review, but doing additional tests so:
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2020
@richardcase richardcase changed the title ✨ feat: initial EKS e2e test ✨ feat: initial EKS e2e tests Dec 14, 2020
@randomvariable
Copy link
Member

randomvariable commented Dec 16, 2020 •
edited
Loading

Let's get a test-infra PR in, configured as a PR presubmit, and then ensure this all works before merging.

Otherwise LGTM.

@richardcase
Copy link
Member Author

Let's get a test-infra PR in, configured as a PR presubmit, and then ensure this all works before merging.

I'll get the PR done now

@randomvariable
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@randomvariable: The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-verify
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-eks

Use /test all to run the following jobs:

  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@randomvariable
Copy link
Member

/test pull-cluster-api-provider-aws-e2e-eks

9 similar comments
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
feat: initial EKS e2e test
78b5794 
Initial EKS e2e tests. Due to the time it takes to provision eks
clusters in AWS we don't create clusters in `BeforeEach` and try
to do tests in steps.

This will be expanded over time
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

3 similar comments
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase
fix: adding required permissions for machine pools
a75251b 
Additional permissions required after testing of managed
machine pools.
@richardcase
feat: added explicit cleanup options to the specs
9e1e241 
Added explicit cleanup to the main eks test. Also disabled the upgrade
test for the time being whilst its debugged
@richardcase
Copy link
Member Author

/test pull-cluster-api-provider-aws-e2e-eks

@richardcase richardcase mentioned this pull request Dec 18, 2020
Closed
@richardcase
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
@randomvariable
Copy link
Member

it worked

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: randomvariable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2afe9e1 into kubernetes-sigs:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dthorsen dthorsen Awaiting requested review from dthorsen

@randomvariable randomvariable Awaiting requested review from randomvariable

Assignees

@randomvariable randomvariable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Managed machine pools fails due to missing permission Create e2e tests for EKS
3 participants
@richardcase @randomvariable @k8s-ci-robot