-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱Add CAPI E2E tests #2138
🌱Add CAPI E2E tests #2138
Conversation
/pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
short term, can we set this up as a new periodic in test-infra ? |
/hold @randomvariable yes, will do. Just testing MachinePool test for now. Will change the focus after that. |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
1 similar comment
/test pull-cluster-api-provider-aws-e2e |
need both |
/hold |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
This PR is ready, can be merged after #2193 is in. |
/approve |
/test pull-cluster-api-provider-aws-e2e |
Test fails due to timeout:
|
/hold cancel |
Let's merge this and the test infra one on Monday, so we don't get a bunch of emails over the weekend if it's there's issues. Please remind me. |
@randomvariable Shall we merge this? |
/test pull-cluster-api-provider-aws-e2e |
/test pull-cluster-api-provider-aws-e2e |
I think we can merge this. |
/test pull-cluster-api-provider-aws-e2e |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: randomvariable The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adding CAPI tests except KCP adoption.
MachinePool test will be uncommented once #2137 is done.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2132