Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]End to End Test for AWSMachinePool #2079

Closed
wants to merge 1 commit into from

Conversation

arghya88
Copy link
Contributor

What this PR does / why we need it:
Adds e2e test for AWSMachinePool
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1983

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rudoi after the PR has been reviewed.
You can assign the PR to them by writing /assign @rudoi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2020
@sedefsavas
Copy link
Contributor

@arghya88 This test was not working due to this issue: #2137

I didn't see this PR when adding all CAPI e2e here: #2138
Do you want to continue working on this one (I can remove this from the other PR) or shall we consolidate these two?

@arghya88
Copy link
Contributor Author

arghya88 commented Dec 3, 2020

@sedefsavas you can consolidate and we can close this PR.

@arghya88 arghya88 closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for AWSMachinePools
3 participants