⚠️ Use v1alpha2 manifests in the helm chart #220
Conversation
k8s-ci-robot
added
cncf-cla: yes
Fedosin
force-pushed
the
chart_v1alpha2
branch
from
c96910f to
b358f27
Compare
|
Looks great, thanks! |
Fedosin
force-pushed
the
chart_v1alpha2
branch
from
ec03062 to
51dd003
Compare
Fedosin
force-pushed
the
chart_v1alpha2
branch
from
51dd003 to
8f00999
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| configSecret: | ||
| name: {{ .name }} | ||
| {{- if .namespace }} | ||
| namespace: {{ .namespace }} | ||
| {{- end }} |
There was a problem hiding this comment.
while I have not tested this and all other changes regarding helm charts, just wanna raise a voice that we have had issues with it recently and if we tested templating changes locally at least?
There was a problem hiding this comment.
we only test provider deployment at the moment https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/e2e/helm_test.go
There was a problem hiding this comment.
Yep, I tested this PR locally, plus we have some e2e tests in place.
The issue there happened because I put the object in the wrong section, so it's not strictly related... I wonder if we can introduce https://github.com/yannh/kubeconform to verify templates we generate.
There was a problem hiding this comment.
I’d recommend using chart tester for that purpose, it has support for linting and verification - https://github.com/helm/chart-testing
There was a problem hiding this comment.
ack, I'll add chart-testing support in another PR
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 98b31e34003098d82e4ee277028b8595cfa91094
|
What this PR does / why we need it:
We introduced v1alpha2 API in #190. In this PR we update manifests in the helm chart to the new version.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #