✨ Add support for addon providers #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
alexander-demicev
force-pushed
the
addon
branch
from
56f8127 to
9764c2b
Compare
Fedosin
reviewed
Aug 25, 2023
| "helm.sh/hook-weight": "1" | ||
| name: {{ $addonNamespace }} | ||
| --- | ||
| apiVersion: operator.cluster.x-k8s.io/v1alpha1 |
There was a problem hiding this comment.
operator.cluster.x-k8s.io/v1alpha2?
|
I suggest to merge this PR first and then update our helm chart to use v1alpha2 here. |
@alexander-demicev PR is merged, can we update this one as well? |
alexander-demicev
force-pushed
the
addon
branch
from
9764c2b to
a3e346e
Compare
|
all fixed |
| @@ -0,0 +1,75 @@ | |||
| /* | |||
| Copyright 2022 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Suggested change
| Copyright 2022 The Kubernetes Authors. | |
| Copyright 2023 The Kubernetes Authors. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 88dfaf4407d72e5a454ac4888f7c94a293eaf58f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for addon providers, it's not different from other providers so the entire process is similar.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #198