Webhook Validate updated pool does not remove in use IPs #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianang
force-pushed
the
pool-downsize-in-use-ips
branch
from
2245338 to
858978e
Compare
adobley
force-pushed
the
pool-downsize-in-use-ips
branch
2 times, most recently
from
1452f8e to
891c3c7
Compare
christianang
force-pushed
the
pool-downsize-in-use-ips
branch
from
891c3c7 to
16af4f4
Compare
Co-authored-by: Christian Ang <[email protected]>
Co-authored-by: Aidan Obley <[email protected]>
christianang
force-pushed
the
pool-downsize-in-use-ips
branch
from
16af4f4 to
549c3c6
Compare
schrej
approved these changes
May 11, 2023
|
For some reason Actions aren't running for this one 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the a pool is still updated and has out of range IPs display the count in the pool status
Relies on #116, we can update this when that is merged
Fixes #117, with the exception of
In addition to the outOfRange status count on the pool we could also add an outOfRange status condition on the IPAddress.This last bit would require changes to the IPAddress resource in core CAPI. The Status field is missing on the IPAddress objects. We think this is okay for now and we can open a new issue for that if we still think it is valuable.