Pools show usage counts #116
Conversation
tylerschultz
force-pushed
the
pool-reconciler
branch
3 times, most recently
from
6783e49 to
f811b8e
Compare
flawedmatrix
force-pushed
the
pool-reconciler
branch
from
f811b8e to
165784a
Compare
adobley
force-pushed
the
pool-reconciler
branch
from
165784a to
39ff513
Compare
tylerschultz
force-pushed
the
pool-reconciler
branch
from
39ff513 to
1eb8a9e
Compare
|
We've rebased, and resolved test failures that resulted. We see that the new controller causes Claims to be reconciled. The scenario where a claim is paused needed special handling. The 'filter' for claims that are not paused are somehow bypassed by the changes the new controller makes to the pool. We've added a new pause check on the claim, which seems correct in any case. We'll spend some time this afternoon manually testing the pause functionality along with these new usage counts and report back later. |
tylerschultz
force-pushed
the
pool-reconciler
branch
from
1eb8a9e to
1735561
Compare
|
Ok, we think this commit is in a good place to merge. The controllers look well behaved. |
|
Since the IPAddressClaim controller has a watch on the pools, and requeues all claims for reconciliation whenever they are updated, this change now causes all claims to be reconciled whenever a new claim is created. lgtm apart from that. |
|
Yeah, that makes sense. Seems simple enough to just do in this PR. We will make an update. Edit: Looking more closely at the watch for the pool. I think what we want is it only queues a change when the pool is unpaused (similar to what we were doing for Cluster pause). I don't think we care about any other updates to the pool itself when reconciling IPAddressClaims. |
christianang
force-pushed
the
pool-reconciler
branch
2 times, most recently
from
2143ede to
22d81c5
Compare
|
That was a great catch @schrej. We've updated the PR to prevent all of the pool's claims from reconciling when the pool status is updated. |
flawedmatrix
force-pushed
the
pool-reconciler
branch
from
22d81c5 to
3c38855
Compare
|
I think we've addressed the last round of feedback, standing by. |
tylerschultz
force-pushed
the
pool-reconciler
branch
2 times, most recently
from
a55e6b9 to
d920352
Compare
tylerschultz
force-pushed
the
pool-reconciler
branch
from
d920352 to
399675e
Compare
InClusterIPPool and GlobalInClusterIPPool receive updates to their status showing the Total count of IPs in the pool's range, the InUse count, and the Free count. IPv6 IP ranges can be enormous (2^128) IPs. Range totals that exceed int are shown as the value of math.MaxInt (arch dependent). Adds a new reconciler for pools. Adds columns to pools for Total, Free, Used Remove Zap logger remnants. Co-authored-by: Edwin Xie <[email protected]> Co-authored-by: Christian Ang <[email protected]> Co-authored-by: Aidan Obley <[email protected]>
tylerschultz
force-pushed
the
pool-reconciler
branch
from
399675e to
428a238
Compare
|
Hi Jakob, we think the PR is once again ready for another round of review. |
|
Thank you! |
InClusterIPPool and GlobalInClusterIPPool receive updates to their status showing the Total count of IPs in the pool's range, the InUse count, and the Free count.
IPv6 IP ranges can be enormous (2^128) IPs. Range totals that exceed int are shown as the value of math.MaxInt (arch dependent).
Adds a new reconciler for pools.
Adds columns to pools for Total, Free, Used
Remove Zap logger remnants.
Fixes #112