Deprecate LoadBalancerIP with Servie LB IP annotation #2428

lzhecheng · 2022-09-28T15:56:50Z

Signed-off-by: Zhecheng Li [email protected]

What type of PR is this?

/kind cleanup
/kind feature
/kind deprecation

What this PR does / why we need it:

Deprecate LoadBalancerIP with Servie LB IP annotation
* Add service.beta.kubernetes.io/azure-load-balancer-ipv4
and service.beta.kubernetes.io/azure-load-balancer-ipv6
* Add an e2e test
* Support retrieve Service CIDR in e2e framework
related: #814

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Deprecate LoadBalancerIP with Servie LB IP annotation. Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

netlify · 2022-09-28T15:56:55Z

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

Name	Link
🔨 Latest commit	`22b2d4c`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/634261855a0bda0008f1bdee
😎 Deploy Preview	https://deploy-preview-2428--kubernetes-sigs-cloud-provide-azure.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

coveralls · 2022-09-29T06:21:07Z

Coverage decreased (-0.008%) to 79.961% when pulling 22b2d4c on lzhecheng:use-lb-ip-annotation into d92742e on kubernetes-sigs:master.

lzhecheng · 2022-09-29T08:48:12Z

/assign @feiskyer

lzhecheng · 2022-09-30T00:18:17Z

/test pull-cloud-provider-azure-e2e-capz

lzhecheng · 2022-09-30T01:21:10Z

/test pull-cloud-provider-azure-e2e-capz

lzhecheng · 2022-10-04T09:29:59Z

/test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz

lzhecheng · 2022-10-04T09:31:54Z

Requested by:
#1920 (comment)

So make this PR first and then the dualstack one.

lzhecheng · 2022-10-05T00:47:53Z

/retest

nilo19 · 2022-10-05T12:11:06Z

pkg/consts/consts.go

+var (
+	// There's no "service.beta.kubernetes.io/azure-load-balancer" annotation before these 2 new ones are added.
+	// Service.Spec.LoadBalancerIP was used and it will be deprecated.
+	ServiceAnnotationLoadBalancerIPDualStack = map[bool]string{


Can we make them two strings? It looks strange to have variables in consts file.

The intention is to make dualstack code cleaner. Since there will be a lot of isIPv6 bool parameters for dualstack support, such map avoids if statements.

lzhecheng · 2022-10-05T14:34:10Z

/test pull-cloud-provider-azure-e2e-capz

feiskyer

And this PR should close issue #1781?

pkg/consts/consts.go

site/content/en/topics/pls-integration.md

site/content/en/topics/shared-ip.md

* Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework Signed-off-by: Zhecheng Li <[email protected]>

feiskyer

/lgtm
/approve

k8s-ci-robot · 2022-10-10T07:38:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [feiskyer,lzhecheng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lzhecheng · 2022-10-10T09:25:40Z

/test pull-cloud-provider-azure-e2e-capz

lzhecheng · 2022-10-11T01:47:49Z

/cherrypick release-1.25

lzhecheng · 2022-10-11T01:47:54Z

/cherrypick release-1.24

lzhecheng · 2022-10-11T01:47:58Z

/cherrypick release-1.23

lzhecheng · 2022-10-11T01:48:03Z

/cherrypick release-1.1

k8s-infra-cherrypick-robot · 2022-10-11T01:48:38Z

@lzhecheng: #2428 failed to apply on top of branch "release-1.25":

Applying: Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework
Using index info to reconstruct a base tree...
M	pkg/consts/consts.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_standard.go
M	pkg/provider/azure_standard_test.go
M	pkg/provider/azure_test.go
M	tests/e2e/network/ensureloadbalancer.go
M	tests/e2e/network/service_annotations.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/service_annotations.go
CONFLICT (content): Merge conflict in tests/e2e/network/service_annotations.go
Auto-merging tests/e2e/network/ensureloadbalancer.go
Auto-merging pkg/provider/azure_test.go
Auto-merging pkg/provider/azure_standard_test.go
Auto-merging pkg/provider/azure_standard.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/consts/consts.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-infra-cherrypick-robot · 2022-10-11T01:48:43Z

@lzhecheng: #2428 failed to apply on top of branch "release-1.24":

Applying: Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework
Using index info to reconstruct a base tree...
M	pkg/consts/consts.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_standard.go
M	pkg/provider/azure_standard_test.go
M	pkg/provider/azure_test.go
A	site/content/en/topics/pls-integration.md
M	tests/e2e/network/ensureloadbalancer.go
M	tests/e2e/network/network_security_group.go
M	tests/e2e/network/service_annotations.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/service_annotations.go
CONFLICT (content): Merge conflict in tests/e2e/network/service_annotations.go
Auto-merging tests/e2e/network/network_security_group.go
Auto-merging tests/e2e/network/ensureloadbalancer.go
Auto-merging site/content/en/development/design-docs/pls-integration.md
CONFLICT (content): Merge conflict in site/content/en/development/design-docs/pls-integration.md
Auto-merging pkg/provider/azure_test.go
Auto-merging pkg/provider/azure_standard_test.go
Auto-merging pkg/provider/azure_standard.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/consts/consts.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-infra-cherrypick-robot · 2022-10-11T01:48:46Z

@lzhecheng: #2428 failed to apply on top of branch "release-1.23":

Applying: Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework
Using index info to reconstruct a base tree...
M	pkg/consts/consts.go
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_standard.go
M	pkg/provider/azure_standard_test.go
M	pkg/provider/azure_test.go
A	site/content/en/topics/pls-integration.md
M	tests/e2e/network/ensureloadbalancer.go
M	tests/e2e/network/network_security_group.go
M	tests/e2e/network/service_annotations.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/service_annotations.go
CONFLICT (content): Merge conflict in tests/e2e/network/service_annotations.go
Auto-merging tests/e2e/network/network_security_group.go
Auto-merging tests/e2e/network/ensureloadbalancer.go
CONFLICT (modify/delete): site/content/en/topics/pls-integration.md deleted in HEAD and modified in Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework. Version Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework of site/content/en/topics/pls-integration.md left in tree.
Auto-merging pkg/provider/azure_test.go
Auto-merging pkg/provider/azure_standard_test.go
Auto-merging pkg/provider/azure_standard.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
Auto-merging pkg/consts/consts.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-infra-cherrypick-robot · 2022-10-11T01:48:50Z

@lzhecheng: #2428 failed to apply on top of branch "release-1.1":

Applying: Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework
Using index info to reconstruct a base tree...
M	pkg/consts/consts.go
M	pkg/provider/azure_loadbalancer.go
M	pkg/provider/azure_loadbalancer_test.go
M	pkg/provider/azure_standard.go
M	pkg/provider/azure_standard_test.go
M	pkg/provider/azure_test.go
A	site/content/en/topics/pls-integration.md
M	tests/e2e/network/ensureloadbalancer.go
M	tests/e2e/network/network_security_group.go
M	tests/e2e/network/service_annotations.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/network/service_annotations.go
CONFLICT (content): Merge conflict in tests/e2e/network/service_annotations.go
Auto-merging tests/e2e/network/network_security_group.go
Auto-merging tests/e2e/network/ensureloadbalancer.go
CONFLICT (modify/delete): site/content/en/topics/pls-integration.md deleted in HEAD and modified in Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework. Version Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework of site/content/en/topics/pls-integration.md left in tree.
Auto-merging pkg/provider/azure_test.go
Auto-merging pkg/provider/azure_standard_test.go
Auto-merging pkg/provider/azure_standard.go
Auto-merging pkg/provider/azure_loadbalancer_test.go
Auto-merging pkg/provider/azure_loadbalancer.go
CONFLICT (content): Merge conflict in pkg/provider/azure_loadbalancer.go
Auto-merging pkg/consts/consts.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Deprecate LoadBalancerIP with Servie LB IP annotation * Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dimakow · 2022-10-31T09:19:32Z

@lzhecheng any plans to fix the cherry-picks for v1.23 through v1.25?

Would be highly appreciated :)

lzhecheng · 2022-11-02T01:33:26Z

@lzhecheng any plans to fix the cherry-picks for v1.23 through v1.25?

Would be highly appreciated :)

Thanks for reminding. Will do.

lzhecheng · 2022-11-02T03:04:44Z

@dimakow oh my bad memory, actually those cherry-picks have already been finished.

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 28, 2022

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2022

k8s-ci-robot requested review from andyzhangx and nilo19 September 28, 2022 15:57

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2022

lzhecheng force-pushed the use-lb-ip-annotation branch 2 times, most recently from 9ea5876 to 4cf6ffc Compare September 29, 2022 06:15

k8s-ci-robot assigned feiskyer Sep 29, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2022

lzhecheng force-pushed the use-lb-ip-annotation branch from 4cf6ffc to 007b07d Compare September 29, 2022 23:19

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2022

lzhecheng force-pushed the use-lb-ip-annotation branch from 007b07d to 4e7469c Compare October 4, 2022 09:24

lzhecheng force-pushed the use-lb-ip-annotation branch 2 times, most recently from 809e448 to 487c139 Compare October 4, 2022 12:09

nilo19 reviewed Oct 5, 2022

View reviewed changes

nilo19 mentioned this pull request Oct 5, 2022

Introduce a new service annotation to replace service.Spec.LoadBalancerIP #1781

Closed

feiskyer reviewed Oct 9, 2022

View reviewed changes

lzhecheng force-pushed the use-lb-ip-annotation branch from 487c139 to e052e68 Compare October 9, 2022 05:50

Deprecate LoadBalancerIP with Servie LB IP annotation

22b2d4c

* Add service.beta.kubernetes.io/azure-load-balancer-ipv4 and service.beta.kubernetes.io/azure-load-balancer-ipv6 * Add an e2e test * Support retrieve Service CIDR in e2e framework Signed-off-by: Zhecheng Li <[email protected]>

lzhecheng force-pushed the use-lb-ip-annotation branch from e052e68 to 22b2d4c Compare October 9, 2022 05:52

feiskyer reviewed Oct 10, 2022

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2022

k8s-ci-robot merged commit 05435ea into kubernetes-sigs:master Oct 10, 2022

lzhecheng deleted the use-lb-ip-annotation branch October 10, 2022 23:01

lzhecheng mentioned this pull request Oct 11, 2022

Feature: Add ServiceAnnotationLoadBalancerIP for deprecated LoadBalancerIP #1920

Closed

yang-wang11 mentioned this pull request Oct 13, 2022

Add an annotation for the Load Balancer service instead of the deprecated field LoadBalancerIP kubernetes/cloud-provider-gcp#371

Closed

rouke-broersma mentioned this pull request Dec 15, 2022

[Question] Is there a replacement for Service.Spec.loadBalancerIP Azure/AKS#3122

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate LoadBalancerIP with Servie LB IP annotation #2428

Deprecate LoadBalancerIP with Servie LB IP annotation #2428

lzhecheng commented Sep 28, 2022 •

edited

Loading

netlify bot commented Sep 28, 2022 •

edited

Loading

coveralls commented Sep 29, 2022 •

edited

Loading

lzhecheng commented Sep 29, 2022

lzhecheng commented Sep 30, 2022

lzhecheng commented Sep 30, 2022

lzhecheng commented Oct 4, 2022

lzhecheng commented Oct 4, 2022 •

edited

Loading

lzhecheng commented Oct 5, 2022

nilo19 Oct 5, 2022

lzhecheng Oct 5, 2022

lzhecheng commented Oct 5, 2022

feiskyer left a comment

feiskyer left a comment

k8s-ci-robot commented Oct 10, 2022

lzhecheng commented Oct 10, 2022

lzhecheng commented Oct 11, 2022

lzhecheng commented Oct 11, 2022

lzhecheng commented Oct 11, 2022

lzhecheng commented Oct 11, 2022

k8s-infra-cherrypick-robot commented Oct 11, 2022

k8s-infra-cherrypick-robot commented Oct 11, 2022

k8s-infra-cherrypick-robot commented Oct 11, 2022

k8s-infra-cherrypick-robot commented Oct 11, 2022

dimakow commented Oct 31, 2022 •

edited

Loading

lzhecheng commented Nov 2, 2022

lzhecheng commented Nov 2, 2022

Deprecate LoadBalancerIP with Servie LB IP annotation #2428

Deprecate LoadBalancerIP with Servie LB IP annotation #2428

Conversation

lzhecheng commented Sep 28, 2022 • edited Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

netlify bot commented Sep 28, 2022 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure ready!

coveralls commented Sep 29, 2022 • edited Loading

lzhecheng commented Sep 29, 2022

lzhecheng commented Sep 30, 2022

lzhecheng commented Sep 30, 2022

lzhecheng commented Oct 4, 2022

lzhecheng commented Oct 4, 2022 • edited Loading

lzhecheng commented Oct 5, 2022

nilo19 Oct 5, 2022

Choose a reason for hiding this comment

lzhecheng Oct 5, 2022

Choose a reason for hiding this comment

lzhecheng commented Oct 5, 2022

feiskyer left a comment

Choose a reason for hiding this comment

feiskyer left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 10, 2022

lzhecheng commented Oct 10, 2022

lzhecheng commented Oct 11, 2022

lzhecheng commented Oct 11, 2022

lzhecheng commented Oct 11, 2022

lzhecheng commented Oct 11, 2022

k8s-infra-cherrypick-robot commented Oct 11, 2022

k8s-infra-cherrypick-robot commented Oct 11, 2022

k8s-infra-cherrypick-robot commented Oct 11, 2022

k8s-infra-cherrypick-robot commented Oct 11, 2022

dimakow commented Oct 31, 2022 • edited Loading

lzhecheng commented Nov 2, 2022

lzhecheng commented Nov 2, 2022

lzhecheng commented Sep 28, 2022 •

edited

Loading

netlify bot commented Sep 28, 2022 •

edited

Loading

coveralls commented Sep 29, 2022 •

edited

Loading

lzhecheng commented Oct 4, 2022 •

edited

Loading

dimakow commented Oct 31, 2022 •

edited

Loading