Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new service annotation to replace service.Spec.LoadBalancerIP #1781

Closed
nilo19 opened this issue May 27, 2022 · 10 comments
Closed
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@nilo19
Copy link
Contributor

nilo19 commented May 27, 2022

What would you like to be added:

According to https://github.com/kubernetes/api/blob/master/core/v1/types.go#L4434, we need to introduce a new annotation to replace the loadBalancerIP, as it will be removed in the future.

Why is this needed:

#1781 (comment)

@nilo19 nilo19 added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 27, 2022
@kanha-gupta
Copy link

/assign

@kanha-gupta
Copy link

what do we have to replace it with ?

@nilo19
Copy link
Contributor Author

nilo19 commented May 28, 2022

We can add an annotation here https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/pkg/consts/consts.go
I recommend service.beta.kubernetes.io/azure-load-balancer-ip, what do you think?

@kanha-gupta
Copy link

I think you are right

@nilo19
Copy link
Contributor Author

nilo19 commented Jun 8, 2022

Hi @kanha-gupta, do you still plan to do this one?

@kanha-gupta kanha-gupta removed their assignment Jun 11, 2022
@AfrouzMashayekhi
Copy link

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2022
@nilo19
Copy link
Contributor Author

nilo19 commented Oct 5, 2022

#2428 to introduce a new annotation.
Use this issue to track as we need to completely remove the service.Spec.LoadBalancerIP in the future.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 4, 2022
@feiskyer
Copy link
Member

feiskyer commented Nov 7, 2022

this was added by #2428.

@feiskyer feiskyer closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
6 participants