-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing IAM permissions #501
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @robbiet480. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @robbiet480! |
Pull Request Test Coverage Report for Build 1103
💛 - Coveralls |
/assign @ddebroy |
/ok-to-test |
/lgtm |
@leakingtapan Any way to bypass the test requirement here? Obviously nothing I changed caused timing tests to fail. |
/retest |
1 similar comment
/retest |
/lgtm |
Please fix commit message |
@leakingtapan Unsure what you're asking here. I don't see any keywords or @ mentions that would trigger a issue. |
Looking at the commit message
Looks it has an @ for the previous author |
@leakingtapan Missed that, all fixed! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leakingtapan, robbiet480 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Originally authored by @pierresteiner at #461. He was unable to complete the PR due to being unable to sign a CLA. I have no such barrier so I am submitting instead.