Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing permission #461

Closed
wants to merge 2 commits into from

Conversation

pierresteiner
Copy link

@pierresteiner pierresteiner commented Mar 10, 2020

Without that, I was getting a nasty error message with 0.5.0

E0310 15:07:10.063122       1 controller.go:910] error syncing claim "835b97fa-62e0-11ea-b720-06ab0707f8ae": failed to provision volume with StorageClass "ebs-sc": rpc error: code = Internal desc = Could not create volume "pvc-835b97fa-62e0-11ea-b720-06ab0707f8ae": failed to get availability zone UnauthorizedOperation: You are not authorized to perform this operation.

Is this a bug fix or adding new feature?: Bug

What is this PR about? / Why do we need it?: It fixes the list of permission

What testing is done?: Yes

EDIT: I did use IRSA, so the pods did not benefit from any permission from the worker. I hope that this is the only missing permission

Without that, I was getting a nasty error message with 0.5.0

```
E0310 15:07:10.063122       1 controller.go:910] error syncing claim "835b97fa-62e0-11ea-b720-06ab0707f8ae": failed to provision volume with StorageClass "ebs-sc": rpc error: code = Internal desc = Could not create volume "pvc-835b97fa-62e0-11ea-b720-06ab0707f8ae": failed to get availability zone UnauthorizedOperation: You are not authorized to perform this operation.
```
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @pierresteiner!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @pierresteiner. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pierresteiner
To complete the pull request process, please assign leakingtapan
You can assign the PR to them by writing /assign @leakingtapan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@k8s-ci-robot k8s-ci-robot requested review from ddebroy and wongma7 March 10, 2020 15:14
@pierresteiner pierresteiner reopened this Mar 10, 2020
@coveralls
Copy link

coveralls commented Mar 10, 2020

Pull Request Test Coverage Report for Build 1077

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.2%) to 78.647%

Files with Coverage Reduction New Missed Lines %
pkg/driver/controller.go 9 88.02%
Totals Coverage Status
Change from base Build 1031: 1.2%
Covered Lines: 1407
Relevant Lines: 1789

💛 - Coveralls

@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2020
@leakingtapan
Copy link
Contributor

@pierresteiner please sign the CLA to get the PR merged.

@leakingtapan
Copy link
Contributor

/check-cla
/retest

@leakingtapan
Copy link
Contributor

@pierresteiner Please sign the CLA to get PR merged. Thx!

@pierresteiner
Copy link
Author

@pierresteiner Please sign the CLA to get PR merged. Thx!

Sadly it is not that easy, this is a corporate account and I am really unsure how to get that done for my company. Working on it; but it might be quicker to recreate the PR.

@leakingtapan
Copy link
Contributor

/check-cla

@leakingtapan
Copy link
Contributor

@pierresteiner could u recreate the PR? Thx

@pierresteiner
Copy link
Author

pierresteiner commented Apr 14, 2020

@leakingtapan can you do it - to circumvent the licence agreement (& close this one)?

I don't need the credit; I'd just be happy that it is fixed for everyone.

@robbiet480
Copy link
Contributor

@pierresteiner Opened a new PR at #501. I can sign a CLA. Thanks for your contribution! @leakingtapan see you at #501 😄!

@leakingtapan
Copy link
Contributor

/close
in favor of #501

@k8s-ci-robot
Copy link
Contributor

@leakingtapan: Closed this PR.

In response to this:

/close
in favor of #501

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants