-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing permission #461
Conversation
Without that, I was getting a nasty error message with 0.5.0 ``` E0310 15:07:10.063122 1 controller.go:910] error syncing claim "835b97fa-62e0-11ea-b720-06ab0707f8ae": failed to provision volume with StorageClass "ebs-sc": rpc error: code = Internal desc = Could not create volume "pvc-835b97fa-62e0-11ea-b720-06ab0707f8ae": failed to get availability zone UnauthorizedOperation: You are not authorized to perform this operation. ```
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @pierresteiner! |
Hi @pierresteiner. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pierresteiner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 1077
💛 - Coveralls |
/ok-to-test |
@pierresteiner please sign the CLA to get the PR merged. |
/check-cla |
@pierresteiner Please sign the CLA to get PR merged. Thx! |
Sadly it is not that easy, this is a corporate account and I am really unsure how to get that done for my company. Working on it; but it might be quicker to recreate the PR. |
/check-cla |
@pierresteiner could u recreate the PR? Thx |
@leakingtapan can you do it - to circumvent the licence agreement (& close this one)? I don't need the credit; I'd just be happy that it is fixed for everyone. |
@pierresteiner Opened a new PR at #501. I can sign a CLA. Thanks for your contribution! @leakingtapan see you at #501 😄! |
/close |
@leakingtapan: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Without that, I was getting a nasty error message with 0.5.0
Is this a bug fix or adding new feature?: Bug
What is this PR about? / Why do we need it?: It fixes the list of permission
What testing is done?: Yes
EDIT: I did use IRSA, so the pods did not benefit from any permission from the worker. I hope that this is the only missing permission