Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

golang 1.10 #2182

Merged
merged 2 commits into from
Jul 4, 2018
Merged

golang 1.10 #2182

merged 2 commits into from
Jul 4, 2018

Conversation

MHBauer
Copy link
Contributor

@MHBauer MHBauer commented Jul 3, 2018

  • golang 1.9 -> 1.10
  • added golang cache to volumes and travis caching

maybe it'll be faster too?

 - golang 1.9 -> 1.10
 - added golang cache to volumes and travis caching
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2018
Copy link
Contributor

@jichenjc jichenjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

just curious , what's the purpose of adding
-v $(CURDIR)/.cache:/root/.cache/ \

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 3, 2018

That's where go's cache is located in the image

$ docker run --rm golang:1.10 go env GOCACHE
/root/.cache/go-build

Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018
@MHBauer MHBauer mentioned this pull request Jul 3, 2018
Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooo! Yes, can't wait to finally get onto go 1.10 after all this time.

As part of this change, you will also need to remove the go build -i flag that I saw you remove in your other PR, it belongs here instead.

@BenTheElder
Copy link

BenTheElder commented Jul 3, 2018

[sorry for the noise, getting the first prowjob presubmit for this repo to run]
/test pull-service-catalog-unit
edit: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubernetes-incubator_service-catalog/2182/pull-service-catalog-unit/1/

@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 3, 2018

I'll take the -i out and see what happens.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018
@MHBauer MHBauer requested a review from carolynvs July 3, 2018 23:07
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 3, 2018

As a baseline, here is the results of building the commit prior:
https://travis-ci.org/kubernetes-incubator/service-catalog/builds/399448590

@jberkhahn
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018
@MHBauer
Copy link
Contributor Author

MHBauer commented Jul 4, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MHBauer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2018
@jberkhahn jberkhahn merged commit c1202aa into kubernetes-retired:master Jul 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. LGTM1 LGTM3 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants