-
Notifications
You must be signed in to change notification settings - Fork 382
Conversation
- golang 1.9 -> 1.10 - added golang cache to volumes and travis caching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just curious , what's the purpose of adding
-v $(CURDIR)/.cache:/root/.cache/ \
That's where go's cache is located in the image $ docker run --rm golang:1.10 go env GOCACHE
/root/.cache/go-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woooo! Yes, can't wait to finally get onto go 1.10 after all this time.
As part of this change, you will also need to remove the go build -i
flag that I saw you remove in your other PR, it belongs here instead.
[sorry for the noise, getting the first prowjob presubmit for this repo to run] |
I'll take the |
As a baseline, here is the results of building the commit prior: |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MHBauer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maybe it'll be faster too?