Update instance loop support for namespaced classes and plans #2133
Conversation
k8s-ci-robot
added
the
size/XXL
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
I've signed it |
k8s-ci-robot
added
cncf-cla: yes
|
Blocked by #2137, which explicitly allows namespaced ref updates to pass through the instance's references subresource. |
* Also adds some namespaced helpers
| @@ -25,3 +25,4 @@ contrib/examples/consumer/Gopkg.lock | |||
| contrib/examples/consumer | |||
| contrib/examples/vendor/* | |||
| integration.test* | |||
| debug.test* | |||
There was a problem hiding this comment.
where is this coming from?
There was a problem hiding this comment.
Was some kind of binary that showed up after running a failed make command, I can't remember which. I'm assuming we would prefer not to have that checked in.
There was a problem hiding this comment.
Yeah I've seen those pop up too after running the tests.
|
/retest |
…etes-retired#2133) * Initial ns instance loop updates * Disambiguate getServiceInstanceWithRefs * Update .gitignore to ignore debug.test * Disambiguate getTestServiceInstanceWithClusterRefs * Also adds some namespaced helpers * Add namespaces to the test type producers * Add TestReconcileServiceInstanceWithNamespacedRefs * Buildable prepareUpdateInstanceRequest * Passing cp * Add sync provision test for namespaced class/plan * Add reconcile async with namespaced refs * Give instance tests their own file * Add ResolveNamespacedReferences test * Add instance DeleteWithNamespacedRefs sync test * Add instance DeleteAsyncWithNamespaced refs test * Fix in progress polling for instances * Add inprogress provision polling test * Cover the nil plan case for last op reqs * Add success async provision ns type test * check properties for nil early * Add inprogress provision async failure ns test * Add inprogress depro poll ns test * Add polling success deprovision ns test * Add failed polling deprovision ns test * Update new files with 2018 copyright header
No description provided.