Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Allow ns refs through ref update strategy #2137

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

eriknelson
Copy link
Contributor

Noticed while testing #2133 that namespaced references were not making it to the validations. They need to be explicitly allowed through.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2018
@k8s-ci-robot k8s-ci-robot requested review from pmorie and vaikas June 20, 2018 16:12
Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@staebler staebler added the LGTM2 label Jun 20, 2018
@staebler staebler merged commit 0dd0429 into kubernetes-retired:master Jun 20, 2018
@eriknelson eriknelson deleted the ns-ref-update branch June 20, 2018 19:10
kikisdeliveryservice pushed a commit to kikisdeliveryservice/service-catalog that referenced this pull request Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants