This repository has been archived by the owner on May 6, 2022. It is now read-only.
Add ServiceClass control loop #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
carolynvs
added
do-not-merge/work-in-progress
eriknelson
force-pushed
the
sc-controller
branch
from
270a0bf
to
fb5522d
Compare
k8s-ci-robot
added
size/L
eriknelson
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
The jenkins build is failing on a known test flake #2036. I'm going to submit a PR today to kill that test with 🔥 until someone can fix it. It's wasting everyone's time right now and since most of us can't kick Jenkins builds, is super annoying. |
|
/retest |
| @@ -0,0 +1,106 @@ | |||
| /* | |||
| Copyright 2017 The Kubernetes Authors. | |||
There was a problem hiding this comment.
Should we make the copy write on these 2018? It's technically a new file.
kikisdeliveryservice
pushed a commit
to kikisdeliveryservice/service-catalog
that referenced
this pull request
Jun 29, 2018
* Add ServiceClass controller * Get tests passing * Update copyright headers to 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1993
TODO: Needs tests, also relies onServiceInstancesupportingServiceClassRef.Namefor filtered lookups.All the dependencies for this PR have been merged, so this should be ready for review/merge.