Add ServiceBroker controller loop #1993
Conversation
k8s-ci-robot
added
size/XXL
docs/walkthrough.md
Outdated
| @@ -66,7 +66,7 @@ We can check the status of the broker: | |||
| $ svcat describe broker ups-broker | |||
| Name: ups-broker | |||
| URL: http://ups-broker-ups-broker.ups-broker.svc.cluster.local | |||
| Status: Ready - Successfully fetched catalog entries from broker @ 2018-03-02 16:03:52 +0000 UTC | |||
| Status: Ready - Successfully fetched cluster catalog entries from broker @ 2018-03-02 16:03:52 +0000 UTC | |||
There was a problem hiding this comment.
This appears to have some of the "cluster catalog" stuff.
There was a problem hiding this comment.
ACK, this is based off an earlier cut of #1911 which should have those fixes. Planning on rebasing this once that PR makes it to master. Will be sure to catch up with you re: the other constant changes and make sure I'm not changing anything that shouldn't.
|
|
||
| serviceClasses := []*v1beta1.ServiceClass(nil) | ||
| servicePlans := []*v1beta1.ServicePlan(nil) | ||
| for _, svc := range in.Services { |
There was a problem hiding this comment.
This is def one area we can simplify in a follow up. I don't necessarily it's worth going to the effort everywhere, but certainly here it is.
| errorDeletingClusterServicePlanReason string = "ErrorDeletingServicePlan" | ||
| errorDeletingClusterServicePlanMessage string = "Error deleting service plan." | ||
| errorListingClusterServiceClassesReason string = "ErrorListingClusterServiceClasses" | ||
| errorListingClusterServiceClassesMessage string = "Error listing cluster service classes." |
There was a problem hiding this comment.
I'm really not certain about the constant changes :-/
| @@ -0,0 +1,790 @@ | |||
| /* | |||
| Copyright 2017 The Kubernetes Authors. | |||
| @@ -0,0 +1,1322 @@ | |||
| /* | |||
| Copyright 2017 The Kubernetes Authors. | |||
|
Looks like a good start! Very excited to see this progressing. |
eriknelson
force-pushed
the
sb-controller
branch
3 times, most recently
from
0e494d7
to
72a2d57
Compare
eriknelson
changed the title
eriknelson
force-pushed
the
sb-controller
branch
4 times, most recently
from
9483f17
to
5196499
Compare
|
CI failure looks legit: |
|
@eriknelson this is still failing CI. Will you take a look? I'd like to get this merged. |
|
@pmorie ack, will update this morning.
…On Wed, May 9, 2018, 12:57 AM Paul Morie ***@***.***> wrote:
@eriknelson <https://github.com/eriknelson> this is still failing CI.
Will you take a look? I'd like to get this merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1993 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZFNUEZE9JtP1aoQCZSWiEonIRd-NQhks5twncngaJpZM4Tmq_1>
.
|
Adds the following: * Extends controller to support namespaced types * ServiceBroker control loop * Initial unit test support
|
@pmorie think it just needed a rebase |
|
oh man, this is huge... LGTM, I think we will have to do some refactoring to allow the same logic to apply to the namespaced and non-namespaced resources later. It is going to be a pain in the butt to make sure we keep the loops the same... |
|
@n3wscott +1, yeah I've been doing my best to try to keep these PRs as tight as possible. I think this will be one of the bigger ones, apart from updating the |
|
/lgtm |
|
oops, forgot we don't use those here... sigh |
Depends on: #1911 & #1988
This PR adds the namespaced ServiceBroker control loop, which will request a broker's catalog and reconcile namespaced ServiceClasses and ServicePlans. Includes required changes to existing controller funcs and some basic initial unit test support.