This repository has been archived by the owner on May 6, 2022. It is now read-only.
Fix common validations regression #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
carolynvs
approved these changes
Mar 28, 2018
| @@ -90,7 +90,7 @@ func validateClusterServiceBrokerSpec(spec *sc.ClusterServiceBrokerSpec, fldPath | |||
| commonErrs := validateCommonServiceBrokerSpec(&spec.CommonServiceBrokerSpec, fldPath) | |||
|
|
|||
| if len(commonErrs) != 0 { | |||
| allErrs = append(commonErrs) | |||
| allErrs = append(allErrs, commonErrs...) | |||
There was a problem hiding this comment.
Doh! I'm saddened that go didn't warn you about that! Silly go...
There was a problem hiding this comment.
I was surprised as well; wondering when that behavior would even be desired? Tricky...
There was a problem hiding this comment.
I am guessing it's the equivalent of this
allErrs = append(allErrs, []error{}...)
orthros
added a commit
to orthros/service-catalog
that referenced
this pull request
Apr 4, 2018
* master: Support provisioning by external id (kubernetes-retired#1756) Add namespaced ServiceBroker API (kubernetes-retired#1881) Enable verbose logging in svcat (kubernetes-retired#1822) Adding ServicePlan (namespaced plans) API (kubernetes-retired#1894) Svcat bind params now supports --params-json (kubernetes-retired#1889) words discussing the automated builds (kubernetes-retired#1885) v0.1.12 release changes don't overwrite generated files before verifying (kubernetes-retired#1891) Update registry code from broker to clusterservicebroker (kubernetes-retired#1880) Credentials remapping (kubernetes-retired#1868) Rename/move existing "ServicePlan" things (kubernetes-retired#1883) Start orphan mitigation after receiving a last operation status for async provisioning (kubernetes-retired#1886) Update of name in example ServiceClass (kubernetes-retired#1878) Cluster-id configmap (kubernetes-retired#1658) Add namespaced ServiceClass API (kubernetes-retired#1859) Fix common validations regression (kubernetes-retired#1882)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a regression that snuck in with my common validation refactoring. ClusterT specific validation errors were getting thrown away due to a bad
commonErrsappend. This correctly appends to the originalallErrsslice.