This repository has been archived by the owner on May 6, 2022. It is now read-only.
Update registry code from broker to clusterservicebroker #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
cncf-cla: yes
eriknelson
changed the title
k8s-ci-robot
added
size/L
eriknelson
changed the title
|
Rebase needed |
eriknelson
force-pushed
the
registry-sb-rename
branch
from
89f36d2
to
426df33
Compare
eriknelson
force-pushed
the
registry-sb-rename
branch
from
426df33
to
7fb6fd7
Compare
|
@pmorie rebased |
arschles
approved these changes
Mar 29, 2018
There was a problem hiding this comment.
I ❤️ the small, incremental PRs that you and @jeremyrickard are doing.
Thanks! LGTM
orthros
added a commit
to orthros/service-catalog
that referenced
this pull request
Apr 4, 2018
* master: Support provisioning by external id (kubernetes-retired#1756) Add namespaced ServiceBroker API (kubernetes-retired#1881) Enable verbose logging in svcat (kubernetes-retired#1822) Adding ServicePlan (namespaced plans) API (kubernetes-retired#1894) Svcat bind params now supports --params-json (kubernetes-retired#1889) words discussing the automated builds (kubernetes-retired#1885) v0.1.12 release changes don't overwrite generated files before verifying (kubernetes-retired#1891) Update registry code from broker to clusterservicebroker (kubernetes-retired#1880) Credentials remapping (kubernetes-retired#1868) Rename/move existing "ServicePlan" things (kubernetes-retired#1883) Start orphan mitigation after receiving a last operation status for async provisioning (kubernetes-retired#1886) Update of name in example ServiceClass (kubernetes-retired#1878) Cluster-id configmap (kubernetes-retired#1658) Add namespaced ServiceClass API (kubernetes-retired#1859) Fix common validations regression (kubernetes-retired#1882)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the registry code and file organization to correctly categorize what was formerly "ServiceBroker" to "ClusterServiceBroker This makes way to introduce the namespaced resource "ServiceBroker" registry code. This PR is a functional NOOP.