FIX: namespaced condition for api resource

[binkkatal]

The current code checks if the api resource is namespaced or not by a faulty condition,

`apiResource.Namespaced = targetResource.GetNamespace() == ""`

If the input kubernetes api-resource has a namespace, the above condition makes the federatedapi-resource not namespaced, due to which the namespaces are not populated in the federatedapi-resource.

Changing the above condition to

`apiResource.Namespaced = targetResource.GetNamespace() != ""`

makes the federated-api-resource as namespaced and sets the namespace as well.

Read more on issue#1181

What this PR does / why we need it:
#1181
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
#1181
Special notes for your reviewer:

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @binkkatal!

It looks like this is your first PR to kubernetes-sigs/kubefed 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubefed has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[binkkatal]

/check-cla

[binkkatal]

/assign @shashidharatd

[jimmidyson]

Would you be able to add some unit tests for this please? I see there haven't been any before so now would be a good time to add them if you don't mind.

[binkkatal]

@jimmidyson working on it

[binkkatal]

@jimmidyson ,

Have added a test case for federating a deployment.
Please have a look.

let me know if you want to add more cases for unit testing

[irfanurrehman]

@binkkatal thanks for doing this and apologies for a late look.
All you need to do is add the builerplate header comment to you test file and its all good to go.

[binkkatal]

@irfanurrehman
added the boilerplate header comment in test file from ./hack/boilerplate.go.txt

[hectorj2f]

/lgtm

Jimmi's request was addressed

[hectorj2f]

The build succeed but it didn't get updated its status in the PR yet 🤔, https://travis-ci.org/github/kubernetes-sigs/kubefed/builds/672496415?utm_source=github_status&utm_medium=notification

[binkkatal]

@hectorj2f ,
Maybe check for jenkins webhook in the webhook section for this repository

[hectorj2f]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: binkkatal, hectorj2f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hectorj2f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment