Namespace not populated in the FederateResources response

[binkkatal]

Input

federate.FederateResources(resources)

where resources contain the input kubernetes object.

{
	"apiVersion": "apps/v1",
	"kind": "Deployment",
	"metadata": {
		"creationTimestamp": null,
		"labels": {
			"run": "apiserver"
		},
		"name": "apiserver",
		"namespace": "demons"
	},
	"spec": {
		"replicas": 1,
		"selector": {
			"matchLabels": {
				"run": "apiserver"
			}
		},
		"strategy": {},
		"template": {
			"metadata": {
				"creationTimestamp": null,
				"labels": {
					"run": "apiserver"
				}
			},
			"spec": {
				"containers": [{
					"image": "biqmind/todo-api",
					"name": "apiserver",
					"ports": [{
						"containerPort": 8080
					}],
					"resources": {}
				}]
			}
		}
	},
	"status": {}
}

What happened:
The namespace was not copied in the response of federate.FederateResources(resources)

{
	"apiVersion": "types.kubefed.io/v1beta1",
	"kind": "FederatedDeployment",
	"metadata": {
		"name": "apiserver"
	},
	"spec": {
		"placement": {
			"clusterSelector": {
				"matchLabels": {}
			}
		},
		"template": {
			"metadata": {
				"labels": {
					"run": "apiserver"
				}
			},
			"spec": {
				"replicas": 1,
				"selector": {
					"matchLabels": {
						"run": "apiserver"
					}
				},
				"strategy": {},
				"template": {
					"metadata": {
						"creationTimestamp": null,
						"labels": {
							"run": "apiserver"
						}
					},
					"spec": {
						"containers": [{
							"image": "biqmind/todo-api",
							"name": "apiserver",
							"ports": [{
								"containerPort": 8080
							}],
							"resources": {}
						}]
					}
				}
			}
		}
	}
}

What you expected to happen:

{
	"apiVersion": "types.kubefed.io/v1beta1",
	"kind": "FederatedDeployment",
	"metadata": {
		"name": "apiserver",
		"namespace": "demons"
	},
	"spec": {
		"placement": {
			"clusterSelector": {
				"matchLabels": {}
			}
		},
		"template": {
			"metadata": {
				"labels": {
					"run": "apiserver"
				}
			},
			"spec": {
				"replicas": 1,
				"selector": {
					"matchLabels": {
						"run": "apiserver"
					}
				},
				"strategy": {},
				"template": {
					"metadata": {
						"creationTimestamp": null,
						"labels": {
							"run": "apiserver"
						}
					},
					"spec": {
						"containers": [{
							"image": "biqmind/todo-api",
							"name": "apiserver",
							"ports": [{
								"containerPort": 8080
							}],
							"resources": {}
						}]
					}
				}
			}
		}
	}
}

How to reproduce it (as minimally and precisely as possible):
use federate.FederateResources(resources) from the federate package

Anything else we need to know?:
would it be right to check if the object is namespaced using this code ?

if i revert this condition , i get the right response and namespaces as in the expected response.

/kind bug

[xunpan]

good catch. this is a bug.
Would you like to contribute code to fix it?

[binkkatal]

@xunpan ,

Will raise a PR this weekend

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[binkkatal]

Closing this under #1199