Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

🌱 Reenabling more Lint tasks #49

Conversation

christopherhein
Copy link
Contributor

This PR should be held open until after kubernetes/test-infra#22090 is merged so we can test that the presubmit hooks is working.

Related

closes #46

Signed-off-by: Chris Hein [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2021
@christopherhein christopherhein changed the title 🌱 Reenabling more Lint tasks [WIP] 🌱 Reenabling more Lint tasks May 6, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2021
@christopherhein
Copy link
Contributor Author

/retest

@christopherhein christopherhein force-pushed the reenable-presubmit-lint branch from 6eaa29e to 4f39b4f Compare May 7, 2021 20:41
@christopherhein
Copy link
Contributor Author

/assign @Fei-Guo

@christopherhein christopherhein changed the title [WIP] 🌱 Reenabling more Lint tasks 🌱 Reenabling more Lint tasks May 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2021
@Fei-Guo
Copy link

Fei-Guo commented May 7, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein, Fei-Guo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Fei-Guo,christopherhein]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e9cd910 into kubernetes-retired:master May 7, 2021
@christopherhein christopherhein deleted the reenable-presubmit-lint branch June 9, 2021 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🌱 Setup Prow Presubmits
3 participants