Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

🌱 Setup Prow Presubmits #46

Closed
christopherhein opened this issue May 5, 2021 · 1 comment · Fixed by #49
Closed

🌱 Setup Prow Presubmits #46

christopherhein opened this issue May 5, 2021 · 1 comment · Fixed by #49
Assignees

Comments

@christopherhein
Copy link
Contributor

We should have our PRs being tested for us with Prow on PR submission so we can have better assurance of the code.

Links

Our pre-submit should run make generate lint test. This should be called from a script like other Cluster API providers so that we can periodically change what it does without needing to update the test-infra repo. EG https://github.com/kubernetes-sigs/cluster-api-provider-aws/tree/main/scripts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant