Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

🌱 Adding scripts directory for prow jobs #48

Merged

Conversation

christopherhein
Copy link
Contributor

This add three CI build scripts, there will be a subsequent PR into kubernetes/test-infra to kick off the presubmits.

Related

Ref #46

Signed-off-by: Chris Hein [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 5, 2021
@christopherhein christopherhein force-pushed the ci-scripts-directory branch from 9db9b9a to 18f0f11 Compare May 5, 2021 21:46
@christopherhein
Copy link
Contributor Author

/milestone v0.1.x

@k8s-ci-robot k8s-ci-robot added this to the v0.1.x milestone May 5, 2021
@christopherhein
Copy link
Contributor Author

/assign @charleszheng44

@christopherhein christopherhein changed the title 🌱 Adding scripts directory for prow jobs [WIP] 🌱 Adding scripts directory for prow jobs May 5, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2021
@christopherhein christopherhein force-pushed the ci-scripts-directory branch from 18f0f11 to eeec9d4 Compare May 5, 2021 22:55
@christopherhein christopherhein changed the title [WIP] 🌱 Adding scripts directory for prow jobs 🌱 Adding scripts directory for prow jobs May 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2021
@christopherhein christopherhein force-pushed the ci-scripts-directory branch 2 times, most recently from 89ecf36 to 1695033 Compare May 6, 2021 00:39
@@ -15,6 +15,12 @@ linters:
- godot
- goerr113
- nestif
# TODO(christopherhein) Reenable these and fix errors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these have been cleaned up in #43 so I once both of these are merged we can clean this up.

@christopherhein christopherhein force-pushed the ci-scripts-directory branch from 1695033 to 36a8cf0 Compare May 6, 2021 04:16
@charleszheng44
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3a84c2d into kubernetes-retired:master May 6, 2021
@christopherhein christopherhein deleted the ci-scripts-directory branch May 6, 2021 04:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants