This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 67
🌱 Adding scripts directory for prow jobs #48
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-retired:master
from
christopherhein:ci-scripts-directory
May 6, 2021
Merged
🌱 Adding scripts directory for prow jobs #48
k8s-ci-robot
merged 1 commit into
kubernetes-retired:master
from
christopherhein:ci-scripts-directory
May 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
May 5, 2021
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christopherhein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
May 5, 2021
christopherhein
force-pushed
the
ci-scripts-directory
branch
from
May 5, 2021 21:46
9db9b9a
to
18f0f11
Compare
/milestone v0.1.x |
/assign @charleszheng44 |
christopherhein
changed the title
🌱 Adding scripts directory for prow jobs
[WIP] 🌱 Adding scripts directory for prow jobs
May 5, 2021
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
May 5, 2021
christopherhein
force-pushed
the
ci-scripts-directory
branch
from
May 5, 2021 22:55
18f0f11
to
eeec9d4
Compare
christopherhein
changed the title
[WIP] 🌱 Adding scripts directory for prow jobs
🌱 Adding scripts directory for prow jobs
May 5, 2021
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
May 5, 2021
christopherhein
force-pushed
the
ci-scripts-directory
branch
2 times, most recently
from
May 6, 2021 00:39
89ecf36
to
1695033
Compare
christopherhein
commented
May 6, 2021
@@ -15,6 +15,12 @@ linters: | |||
- godot | |||
- goerr113 | |||
- nestif | |||
# TODO(christopherhein) Reenable these and fix errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these have been cleaned up in #43 so I once both of these are merged we can clean this up.
Signed-off-by: Chris Hein <[email protected]>
christopherhein
force-pushed
the
ci-scripts-directory
branch
from
May 6, 2021 04:16
1695033
to
36a8cf0
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
May 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add three CI build scripts, there will be a subsequent PR into kubernetes/test-infra to kick off the presubmits.
Related
Ref #46
Signed-off-by: Chris Hein [email protected]