This repository has been archived by the owner on May 6, 2022. It is now read-only.
Remove regex validation of service class external IDs #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
cncf-cla: yes
jberkhahn
requested review from
duglin
and removed request for
carolynvs and
nilebox
MHBauer
previously requested changes
Aug 27, 2018
| @@ -248,10 +257,10 @@ func TestValidateServiceClass(t *testing.T) { | |||
| valid: false, | |||
| }, | |||
| { | |||
| name: "invalid serviceClass - invalid guid", | |||
| name: "invalid serviceClass - invalid externalID", | |||
There was a problem hiding this comment.
dup of test immediately above.
| serviceClass: func() *servicecatalog.ClusterServiceClass { | ||
| s := validClusterServiceClass() | ||
| s.Spec.ExternalID = "1234-4354a\\%-49b" | ||
| s.Spec.ExternalID = "" |
There was a problem hiding this comment.
dup of test immediately above.
| @@ -62,14 +62,23 @@ func TestValidateClusterServiceClass(t *testing.T) { | |||
| valid: true, | |||
| }, | |||
| { | |||
| name: "valid serviceClass - period in GUID", | |||
| name: "valid serviceClass - period in externalID:2", | |||
| serviceClass: func() *servicecatalog.ClusterServiceClass { | ||
| s := validClusterServiceClass() | ||
| s.Spec.ExternalID = "4315f5e1-0139-4ecf-9706-9df0aff33e5a.plan-name" | ||
| return s | ||
| }(), | ||
| valid: true, | ||
| }, | ||
| { | ||
| name: "valid serviceClass - underscore in ExternalID", | ||
| serviceClass: func() *servicecatalog.ClusterServiceClass { |
There was a problem hiding this comment.
also need this test below for ServiceClass, (in theory)
jberkhahn
force-pushed
the
externalid_underscore_fix
branch
from
ec31964
to
bf26320
Compare
|
/retest |
|
/assign @duglin |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: duglin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the OSB API spec, although external ID is recommended to be a GUID, it can be any non-empty string. So, remove the regex validation, and add a validation to assert it's non-empty.