Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prow update master #465

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Prow update master #465

merged 6 commits into from
Dec 11, 2024

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Dec 5, 2024

/kind cleanup

Update release-tools according to kubernetes-csi/csi-release-tools#7

Squashed 'release-tools/' changes from 227577e0..734c2b95

734c2b95 Merge pull request #265 from Rakshith-R/consider-main-branch
f95c855b Merge pull request #262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
e31de525 Merge pull request #261 from huww98/golang
fd153a9e Bump golang to 1.23.1
a8b3d050 pull-test.sh: fix "git subtree pull" errors
6b05f0fc use new GOTOOLCHAIN env to manage go version

git-subtree-dir: release-tools
git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97

NONE

@avorima
Squashed 'release-tools/' changes from 227577e0..734c2b95
bcb7b92 
kubernetes-csi/csi-release-tools@734c2b95 Merge kubernetes-csi/csi-release-tools#265 from Rakshith-R/consider-main-branch
kubernetes-csi/csi-release-tools@f95c855b Merge kubernetes-csi/csi-release-tools#262 from huww98/golang-toolchain
kubernetes-csi/csi-release-tools@3c8d966f Treat main branch as equivalent to master branch
kubernetes-csi/csi-release-tools@e31de525 Merge kubernetes-csi/csi-release-tools#261 from huww98/golang
kubernetes-csi/csi-release-tools@fd153a9e Bump golang to 1.23.1
kubernetes-csi/csi-release-tools@a8b3d050 pull-test.sh: fix "git subtree pull" errors
kubernetes-csi/csi-release-tools@6b05f0fc use new GOTOOLCHAIN env to manage go version

git-subtree-dir: release-tools
git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97
@avorima
release-tools: update
01c7e28 
Commit summary:
Squashed 'release-tools/' changes from 227577e0..734c2b95

[734c2b95](kubernetes-csi/csi-release-tools@734c2b95) Merge [pull request kubernetes-csi#265](kubernetes-csi/csi-release-tools#265) from Rakshith-R/consider-main-branch
[f95c855b](kubernetes-csi/csi-release-tools@f95c855b) Merge [pull request kubernetes-csi#262](kubernetes-csi/csi-release-tools#262) from huww98/golang-toolchain
[3c8d966f](kubernetes-csi/csi-release-tools@3c8d966f) Treat main branch as equivalent to master branch
[e31de525](kubernetes-csi/csi-release-tools@e31de525) Merge [pull request kubernetes-csi#261](kubernetes-csi/csi-release-tools#261) from huww98/golang
[fd153a9e](kubernetes-csi/csi-release-tools@fd153a9e) Bump golang to 1.23.1
[a8b3d050](kubernetes-csi/csi-release-tools@a8b3d050) pull-test.sh: fix "git subtree pull" errors
[6b05f0fc](kubernetes-csi/csi-release-tools@6b05f0fc) use new GOTOOLCHAIN env to manage go version

git-subtree-dir: release-tools
git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97
Signed-off-by: Mario Valderrama <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 5, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @avorima. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2024
@avorima avorima marked this pull request as ready for review December 5, 2024 19:54
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2024
TerryHowe
TerryHowe reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this captured this change kubernetes-csi/csi-release-tools#259

@avorima
Squashed 'release-tools/' changes from 734c2b95..98f23071
3514c82 
kubernetes-csi/csi-release-tools@98f23071 Merge kubernetes-csi/csi-release-tools#260 from TerryHowe/update-csi-driver-version
kubernetes-csi/csi-release-tools@e9d8712d Merge kubernetes-csi/csi-release-tools#259 from stmcginnis/deprecated-kind-kube-root
kubernetes-csi/csi-release-tools@faf79ff6 Remove --kube-root deprecated kind argument
kubernetes-csi/csi-release-tools@18b6ac6d chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
@avorima
release-tools: update
8f2cc7e
@jsafrane
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2024
@avorima
Squashed 'release-tools/' changes from 98f23071..406a79ac
2607470 
406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d Set GOMODCACHE to avoid re-download toolchain

git-subtree-dir: release-tools
git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f
@avorima
release-tools: update
71e3197
@jsafrane
Copy link
Contributor

/retest-required

@jsafrane
Copy link
Contributor

Can you please update with the latest release-tools, to have them the same in all repos?

@avorima
Copy link
Contributor Author

avorima commented Dec 11, 2024

Latest commit kubernetes-csi/csi-release-tools@406a79a is already included 2607470

@jsafrane
Copy link
Contributor

I see
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avorima, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9b32fcc into kubernetes-csi:master Dec 11, 2024
6 checks passed
@avorima avorima deleted the prow-update-master branch December 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TerryHowe TerryHowe TerryHowe left review comments

@carlory carlory Awaiting requested review from carlory

@humblec humblec Awaiting requested review from humblec

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avorima @k8s-ci-robot @jsafrane @TerryHowe