Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CSI driver version to 1.15 #260

Merged

Conversation

TerryHowe
Copy link
Contributor

@TerryHowe TerryHowe commented Oct 9, 2024

Updating release tools similar to:

kubernetes-csi/csi-test#431

for:
kubernetes-csi/csi-test#560

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @TerryHowe!

It looks like this is your first PR to kubernetes-csi/csi-release-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-release-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @TerryHowe. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2024
@TerryHowe
Copy link
Contributor Author

TerryHowe commented Oct 19, 2024

/release-note-none

@jsafrane
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Dec 6, 2024

/retest

remote: fatal: could not fetch b18c53581356c52a220a2baf1c8cf3fd9c57dda6 from promisor remote
error: git upload-pack: git-pack-objects died with error.

is it a git hiccup or is is permanent?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 6, 2024

@TerryHowe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-csi-release-tools-csi-test 18b6ac6 link false /test pull-kubernetes-csi-release-tools-csi-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

jsafrane commented Dec 6, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@TerryHowe
Copy link
Contributor Author

@jsafrane
Copy link
Contributor

jsafrane commented Dec 9, 2024

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 98f2307 into kubernetes-csi:master Dec 9, 2024
6 of 7 checks passed
@jsafrane
Copy link
Contributor

jsafrane commented Dec 9, 2024

Thanks a lot for your PRs!

avorima added a commit to avorima/node-driver-registrar that referenced this pull request Dec 9, 2024
kubernetes-csi/csi-release-tools@98f23071 Merge kubernetes-csi/csi-release-tools#260 from TerryHowe/update-csi-driver-version
kubernetes-csi/csi-release-tools@e9d8712d Merge kubernetes-csi/csi-release-tools#259 from stmcginnis/deprecated-kind-kube-root
kubernetes-csi/csi-release-tools@faf79ff6 Remove --kube-root deprecated kind argument
kubernetes-csi/csi-release-tools@18b6ac6d chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
avorima added a commit to avorima/external-resizer that referenced this pull request Dec 9, 2024
kubernetes-csi/csi-release-tools@98f23071 Merge kubernetes-csi/csi-release-tools#260 from TerryHowe/update-csi-driver-version
kubernetes-csi/csi-release-tools@e9d8712d Merge kubernetes-csi/csi-release-tools#259 from stmcginnis/deprecated-kind-kube-root
kubernetes-csi/csi-release-tools@faf79ff6 Remove --kube-root deprecated kind argument
kubernetes-csi/csi-release-tools@18b6ac6d chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
avorima added a commit to avorima/external-attacher that referenced this pull request Dec 9, 2024
kubernetes-csi/csi-release-tools@98f23071 Merge kubernetes-csi/csi-release-tools#260 from TerryHowe/update-csi-driver-version
kubernetes-csi/csi-release-tools@e9d8712d Merge kubernetes-csi/csi-release-tools#259 from stmcginnis/deprecated-kind-kube-root
kubernetes-csi/csi-release-tools@faf79ff6 Remove --kube-root deprecated kind argument
kubernetes-csi/csi-release-tools@18b6ac6d chore: update CSI driver version to 1.15

git-subtree-dir: release-tools
git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants