Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate kubelet-registration-probe #316

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Deprecate kubelet-registration-probe #316

merged 1 commit into from
Sep 7, 2023

Conversation

mattcary
Copy link
Contributor

@mattcary mattcary commented Jul 21, 2023 •
edited by jsafrane
Loading

This also removes an unnecessary write to the root filesystem which prevents this driver as running under a readOnlyRootFilesystem security context

Fixes #309, #315

/assign @mauriciopoppe

/kind cleanup

Action required: deprecated `kubelet-registration-probe` and removed related code. node-driver-registrar on Windows now requires Kubernetes with [fixed handling of registration sockets](https://github.com/kubernetes/kubernetes/pull/110075) that is part of Kubernetes v1.23.10, v1.24.4, v1.25.0, and newer. There are no changes on Linux, i.e. Kubernetes v1.13 is still the minimal one.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 21, 2023
mauriciopoppe
mauriciopoppe reviewed Jul 22, 2023
View reviewed changes
Copy link
Member

@mauriciopoppe mauriciopoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help removing the code, could you also update README.md please?

cmd/csi-node-driver-registrar/main.go Outdated Show resolved Hide resolved
cmd/csi-node-driver-registrar/main.go Show resolved Hide resolved
cmd/csi-node-driver-registrar/main.go Show resolved Hide resolved
@mattcary
Copy link
Contributor Author

Thanks for the review, I'll update the README which I also overlooked.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2023
mauriciopoppe
mauriciopoppe reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@mauriciopoppe mauriciopoppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing all the dead code, I think you might have missed the README.md changes.

cmd/csi-node-driver-registrar/main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2023
@mauriciopoppe
Copy link
Member

hey @mattcary, friendly ping about the node-driver-registrar change about the kubelet-registration-probe

@mauriciopoppe mauriciopoppe mentioned this pull request Aug 16, 2023
Merged
@mattcary
Deprecate kubelet-registration-probe and remove an unneccesary write …
25eb1c9 
…to the root filesystem

Change-Id: I42f436e7295adf708df15e57d0c24a5175c67495
@mattcary
Copy link
Contributor Author

Sorry for the delay. Done.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2023
@mauriciopoppe
Copy link
Member

/lgtm
/assign @msau42

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@jsafrane
Copy link
Contributor

jsafrane commented Sep 6, 2023

/appprove

@jsafrane
Copy link
Contributor

jsafrane commented Sep 7, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@jsafrane
Copy link
Contributor

jsafrane commented Sep 7, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 284023f into kubernetes-csi:master Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 8, 2023
@mauriciopoppe mauriciopoppe mentioned this pull request Sep 13, 2023
Closed
@mauriciopoppe mauriciopoppe mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauriciopoppe mauriciopoppe mauriciopoppe left review comments

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@sunnylovestiramisu sunnylovestiramisu Awaiting requested review from sunnylovestiramisu

Assignees

@mauriciopoppe mauriciopoppe

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate --mode option kubelet-registration-probe
5 participants
@mattcary @mauriciopoppe @jsafrane @k8s-ci-robot @msau42