Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary write to root filesystem #315

Closed
mattcary opened this issue Jul 21, 2023 · 5 comments
Closed

Unnecessary write to root filesystem #315

mattcary opened this issue Jul 21, 2023 · 5 comments
Assignees

Comments

@mattcary
Copy link
Contributor

cmd/main.go:GetInfo writes to registrationProbePath, even when --mode=registration. But kubelet-registration-path refers to /var/lib/kubelet, which is not mounted into the registrar container in --mode=registration.

/assign @mattcary

@mauriciopoppe
Copy link
Member

This is related to #309, I wrote some strategies there about how to make it work by making the --mode=kubelet-registration-info always return exit code 0 and removing all the other supporting code including the unnecessary write to the root fs.

@mattcary
Copy link
Contributor Author

I think it is not correct to use --kubelet-registration-path in mode=registration, as it's a container local path and not actually /var/lib/kubelet. So we should be able to make that change immediately? Let me start a PR to be concrete about what I mean.

@jsafrane

@mauriciopoppe
Copy link
Member

yes, we can do the changes for #309 immediately i.e. #309 (comment)

@mattcary
Copy link
Contributor Author

Oh, I see what you mean. Thanks for clarifying. I'll do that.

@mauriciopoppe
Copy link
Member

#316 implemented #315 (comment). With the new release the write no longer to the root filesystem no longer happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants