Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #190: Correct the handler used in serving http requests #193

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Automated cherry pick of #190: Correct the handler used in serving http requests #193

merged 1 commit into from
Apr 22, 2022

Conversation

mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Apr 14, 2022 •
edited
Loading

Cherry pick of #190 on release-2.5.

#190: Correct the handler used in serving http requests

For details on the cherry pick process, see the cherry pick requests page.

Corrects the handler used to serve http requests, the /healthz and /debug/ endpoints are available now.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 14, 2022
@mauriciopoppe
Copy link
Member Author

/cc @jingxu97

@k8s-ci-robot k8s-ci-robot requested a review from jingxu97 April 14, 2022 17:31
@mauriciopoppe
Copy link
Member Author

/cc @msau42
/uncc @j-griffith @pohly

@k8s-ci-robot k8s-ci-robot requested review from msau42 and removed request for pohly and j-griffith April 22, 2022 04:13
@msau42
Copy link
Collaborator

msau42 commented Apr 22, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mauriciopoppe, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 81ff422 into kubernetes-csi:release-2.5 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mauriciopoppe @msau42 @k8s-ci-robot @cnmcavoy