-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the handler used in serving http requests #190
Correct the handler used in serving http requests #190
Conversation
Welcome @cnmcavoy! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cnmcavoy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @cnmcavoy. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
55e52b5
to
83c6efc
Compare
/ok-to-test Thank you for finding the root cause and quickly submitting a fix! |
@mauriciopoppe @msau42 Could we merge this and release new version? This blocks updating |
Merging with the Github UI, I'll work on creating a new patch release |
…190-upstream-release-2.5 Automated cherry pick of #190: Correct the handler used in serving http requests
What type of PR is this?
/kind bug
What this PR does / why we need it:
Corrects the handler used serving http requests. The existing handler for pprof and healthz is not wired up correctly and never responds to requests made, when configured.
Which issue(s) this PR fixes:
Fixes #188
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?: