Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update image and tag parameter for Dockerfile.Windows #109

Closed
wants to merge 1 commit into from
Closed

Update image and tag parameter for Dockerfile.Windows #109

wants to merge 1 commit into from

Conversation

jingxu97
Copy link
Contributor

@jingxu97 jingxu97 commented Sep 1, 2020

Dockerfile.Windows has two container images, servercore and nanoserver,
use seperate parameter for them.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@jingxu97
Update image and tag parameter for Dockerfile.Windows
d31425d 
Dockerfile.Windows has two container images, servercore and nanoserver,
use seperate parameter for them.
@k8s-ci-robot
Copy link
Contributor

@jingxu97: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jingxu97
To complete the pull request process, please assign saad-ali
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2020
@msau42
Copy link
Collaborator

msau42 commented Sep 1, 2020

Can you reference the PR that this was cherry picked from in the title, and also add the same release note. Something is also strange because it says the PR is targeting the master branch instead of release-2.0

@jingxu97 jingxu97 closed this Sep 3, 2020
@pohly pohly mentioned this pull request Oct 27, 2020
Merged
pohly added a commit to pohly/node-driver-registrar that referenced this pull request Oct 27, 2020
@pohly
Squashed 'release-tools/' changes from a0f195cc..4aff857d
fc2bc0c 
4aff857d Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults
0427289d Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround
9a370ab9 prow.sh: work around "kind build node-image" failure
522361ec prow.sh: only run alpha tests for latest Kubernetes release
22c0395c Merge pull request kubernetes-csi#108 from bnrjee/master
b5b447b5 Add go ldflags using LDFLAGS at the time of compilation
16f4afbd Merge pull request kubernetes-csi#107 from pohly/kind-update
7bcee13d prow.sh: update to kind 0.9, support Kubernetes 1.19
df518fbd prow.sh: usage of Bazel optional
c3afd427 Merge pull request kubernetes-csi#104 from xing-yang/snapshot
dde93b22 Update to snapshot-controller v3.0.0

git-subtree-dir: release-tools
git-subtree-split: 4aff857d88149e07951fcd1322f462f765401a86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingxu97 @k8s-ci-robot @msau42