Update image and tag parameter for Dockerfile.Windows #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile.Windows has two container images, servercore and nanoserver, use seperate parameter for them.
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-ci-robot
added
the
size/S
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
I added one. PTAL |
|
lgtm, are you waiting on someone from the windows team to take a look? Otherwise you can cancel the hold if it's ready |
|
@ddebroy PTAL |
|
/cancel hold |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Looks good to me. |
pohly
added a commit
to pohly/node-driver-registrar
that referenced
this pull request
Oct 27, 2020
22c0395c Merge pull request kubernetes-csi#108 from bnrjee/master b5b447b5 Add go ldflags using LDFLAGS at the time of compilation 16f4afbd Merge pull request kubernetes-csi#107 from pohly/kind-update 7bcee13d prow.sh: update to kind 0.9, support Kubernetes 1.19 df518fbd prow.sh: usage of Bazel optional c3afd427 Merge pull request kubernetes-csi#104 from xing-yang/snapshot dde93b22 Update to snapshot-controller v3.0.0 git-subtree-dir: release-tools git-subtree-split: 22c0395c9cb16a65d47197b405a8cc3cc82fced9
This was referenced Oct 27, 2020
pohly
added a commit
to pohly/node-driver-registrar
that referenced
this pull request
Oct 27, 2020
4aff857d Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults 0427289d Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround 9a370ab9 prow.sh: work around "kind build node-image" failure 522361ec prow.sh: only run alpha tests for latest Kubernetes release 22c0395c Merge pull request kubernetes-csi#108 from bnrjee/master b5b447b5 Add go ldflags using LDFLAGS at the time of compilation 16f4afbd Merge pull request kubernetes-csi#107 from pohly/kind-update 7bcee13d prow.sh: update to kind 0.9, support Kubernetes 1.19 df518fbd prow.sh: usage of Bazel optional c3afd427 Merge pull request kubernetes-csi#104 from xing-yang/snapshot dde93b22 Update to snapshot-controller v3.0.0 git-subtree-dir: release-tools git-subtree-split: 4aff857d88149e07951fcd1322f462f765401a86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile.Windows has two container images, servercore and nanoserver,
use seperate parameter for them.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: