Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock ControllerGetVolume/NodeGetVolumeStats/ListVolumes RPCs to test controller/agent here #9

Closed
NickrenREN opened this issue May 13, 2020 · 9 comments · Fixed by kubernetes-csi/csi-test#268
Assignees

Comments

@NickrenREN
Copy link
Contributor

No description provided.

@NickrenREN
Copy link
Contributor Author

/assign @fengzixu

@k8s-ci-robot
Copy link
Contributor

@NickrenREN: GitHub didn't allow me to assign the following users: fengzixu.

Note that only kubernetes-csi members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @fengzixu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fengzixu
Copy link
Contributor

Please assign to me

@NickrenREN
Copy link
Contributor Author

@fengzixu You may need to add support in csi-test repo for volume health monitor.
Example: kubernetes-csi/csi-test#160

@fengzixu
Copy link
Contributor

Implementing

@fengzixu
Copy link
Contributor

When I resolved this issue, I found the GET_VOLUME_HEALTH capability doesn't exist in spec repository. I think it was replaced by GET_VOLUME_CONDITION. Right?

And, I found the ListVolumes RPC interface has been mocked. https://github.com/kubernetes-csi/csi-test/blob/613e9285fbb8552aae5827286600146dff19db62/mock/service/controller.go#L329

@fengzixu
Copy link
Contributor

Not sure if this PR can satisfy our mock requirement. Please check: kubernetes-csi/csi-test#268

@xing-yang
Copy link
Contributor

Yes, it is GET_VOLUME_CONDITION.

ListVolumes is an existing RPC. We just added volume_condition in its response.

@xing-yang
Copy link
Contributor

You can take a look of this PR to see what changes are added to CSI spec to support volume health: container-storage-interface/spec#415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants