Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make mock driver support volume expand feature #160

Merged
merged 2 commits into from
Feb 6, 2019
Merged

make mock driver support volume expand feature #160

merged 2 commits into from
Feb 6, 2019

Conversation

mlmhl
Copy link
Contributor

@mlmhl mlmhl commented Jan 30, 2019

The volume resize feature has been already merged into the CSI spec, this PR makes the mock driver implements ControllerExpandVolume and NodeExpandVolume method so that we can use it to test the external-resizer.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 30, 2019
@mlmhl
Copy link
Contributor Author

mlmhl commented Jan 30, 2019

/assign @gnufied

@mlmhl mlmhl mentioned this pull request Jan 30, 2019
Merged
@gnufied
Copy link
Contributor

gnufied commented Feb 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2019
@gnufied
Copy link
Contributor

gnufied commented Feb 6, 2019

We probably also need online/offline capabilities added to identity service but I think we can do this as a follow up.

msau42
msau42 reviewed Feb 6, 2019
View reviewed changes
mock/service/service.go
DisableAttach bool
DriverName string
AttachLimit int64
NodeExpansionRequired bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want ControllerExpansion to be configurable? In case you want to do tests against a driver that doesn't support expansion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could but can we do this as a follow up? I would also like to make online and offline configurable.

@msau42
Copy link
Collaborator

msau42 commented Feb 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlmhl, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit d400bcc into kubernetes-csi:master Feb 6, 2019
@mlmhl
Copy link
Contributor Author

mlmhl commented Feb 11, 2019

@gnufied @msau42 Sorry for the late, I will solve these issues in a follow up PR.

This was referenced Feb 21, 2019
Merged
Closed
suneeth51 pushed a commit to suneeth51/csi-test that referenced this pull request Sep 11, 2019
@k8s-ci-robot
Merge pull request kubernetes-csi#160 from mlmhl/resize
a25d0b1 
 make mock driver support volume expand feature
@NickrenREN NickrenREN mentioned this pull request May 18, 2020
Closed
stmcginnis pushed a commit to stmcginnis/csi-test that referenced this pull request Oct 9, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#160 from pohly/kind-update
d7146c7 
prow.sh: update to KinD v0.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@gnufied gnufied gnufied left review comments

@pohly pohly Awaiting requested review from pohly

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@gnufied gnufied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlmhl @gnufied @msau42 @k8s-ci-robot