-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow update master #606
Prow update master #606
Conversation
kubernetes-csi/csi-release-tools@734c2b95 Merge kubernetes-csi/csi-release-tools#265 from Rakshith-R/consider-main-branch kubernetes-csi/csi-release-tools@f95c855b Merge kubernetes-csi/csi-release-tools#262 from huww98/golang-toolchain kubernetes-csi/csi-release-tools@3c8d966f Treat main branch as equivalent to master branch kubernetes-csi/csi-release-tools@e31de525 Merge kubernetes-csi/csi-release-tools#261 from huww98/golang kubernetes-csi/csi-release-tools@fd153a9e Bump golang to 1.23.1 kubernetes-csi/csi-release-tools@a8b3d050 pull-test.sh: fix "git subtree pull" errors kubernetes-csi/csi-release-tools@6b05f0fc use new GOTOOLCHAIN env to manage go version git-subtree-dir: release-tools git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97
Commit summary: Squashed 'release-tools/' changes from 227577e0..734c2b95 [734c2b95](kubernetes-csi/csi-release-tools@734c2b95) Merge [pull request kubernetes-csi#265](kubernetes-csi/csi-release-tools#265) from Rakshith-R/consider-main-branch [f95c855b](kubernetes-csi/csi-release-tools@f95c855b) Merge [pull request kubernetes-csi#262](kubernetes-csi/csi-release-tools#262) from huww98/golang-toolchain [3c8d966f](kubernetes-csi/csi-release-tools@3c8d966f) Treat main branch as equivalent to master branch [e31de525](kubernetes-csi/csi-release-tools@e31de525) Merge [pull request kubernetes-csi#261](kubernetes-csi/csi-release-tools#261) from huww98/golang [fd153a9e](kubernetes-csi/csi-release-tools@fd153a9e) Bump golang to 1.23.1 [a8b3d050](kubernetes-csi/csi-release-tools@a8b3d050) pull-test.sh: fix "git subtree pull" errors [6b05f0fc](kubernetes-csi/csi-release-tools@6b05f0fc) use new GOTOOLCHAIN env to manage go version git-subtree-dir: release-tools git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97 Signed-off-by: Mario Valderrama <[email protected]>
Hi @avorima. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally would contain kubernetes-csi/csi-release-tools#259
kubernetes-csi/csi-release-tools@98f23071 Merge kubernetes-csi/csi-release-tools#260 from TerryHowe/update-csi-driver-version kubernetes-csi/csi-release-tools@e9d8712d Merge kubernetes-csi/csi-release-tools#259 from stmcginnis/deprecated-kind-kube-root kubernetes-csi/csi-release-tools@faf79ff6 Remove --kube-root deprecated kind argument kubernetes-csi/csi-release-tools@18b6ac6d chore: update CSI driver version to 1.15 git-subtree-dir: release-tools git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
@jsafrane i see this pull-kubernetes-csi-external-attacher-1-29-on-kubernetes-1-29 job fail on some other similar pull requests too. seemingly with the same error message: |
I don't. Someone needs to dive into the scripts used to run the tests and where they come from and why they don't work. I don't have much "secret" knowledge here. |
406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache 9cec273d Set GOMODCACHE to avoid re-download toolchain git-subtree-dir: release-tools git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f
/retest-required |
Thanks for the PR! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avorima, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I can see kubernetes-csi/csi-release-tools#267 helped |
/kind cleanup
Update release-tools according to kubernetes-csi/csi-release-tools#7
Squashed 'release-tools/' changes from 227577e0..734c2b95
734c2b95 Merge pull request #265 from Rakshith-R/consider-main-branch
f95c855b Merge pull request #262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
e31de525 Merge pull request #261 from huww98/golang
fd153a9e Bump golang to 1.23.1
a8b3d050 pull-test.sh: fix "git subtree pull" errors
6b05f0fc use new GOTOOLCHAIN env to manage go version
git-subtree-dir: release-tools
git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97