Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts: Fix image repo and version #146

Closed

Conversation

mayankshah1607
Copy link
Contributor

@mayankshah1607 mayankshah1607 commented Nov 11, 2020

Signed-off-by: Mayank Shah [email protected]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
fix image repo and version in helm chart and example

Which issue(s) this PR fixes:

Fixes #145

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mayankshah1607
To complete the pull request process, please assign msau42 after the PR has been reviewed.
You can assign the PR to them by writing /assign @msau42 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 11, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 357230395

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.658%

Totals Coverage Status
Change from base Build 355709391: 0.0%
Covered Lines: 625
Relevant Lines: 713

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

@mayankshah1607: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@mayankshah1607: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-csi-driver-smb-windows-build 2d9cce8 link /test pull-csi-driver-smb-windows-build
pull-csi-driver-smb-unit 2d9cce8 link /test pull-csi-driver-smb-unit
pull-csi-driver-smb-verify 2d9cce8 link /test pull-csi-driver-smb-verify
pull-csi-driver-smb-sanity 2d9cce8 link /test pull-csi-driver-smb-sanity
pull-csi-driver-smb-e2e-windows 2d9cce8 link /test pull-csi-driver-smb-e2e-windows
pull-csi-driver-smb-e2e 2d9cce8 link /test pull-csi-driver-smb-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Usage of CSI Provisioner in csi-smb-controller
3 participants